buildd-manager failure counting is too trigger-happy when killing virtual builders

Reported by William Grant on 2012-08-22
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Colin Watson

Bug Description

lp.buildmaster.manager.assessFailureCounts is a little too trigger-happy when it determines that a virtual builder has failed:

    if builder.failure_count > job_failure_count:
        if current_job is not None:
            current_job.reset()
        if builder.failure_count >= Builder.FAILURE_THRESHOLD:
            builder.failBuilder(fail_notes)

If a virtual builder has failed, we immediately try manually ppa-resetting it. buildd-manager could do that for us before giving up.

This is closely related to bug #1039927.

Related branches

Haw Loeung (hloeung) on 2012-08-22
tags: added: canonical-losa-lp
William Grant (wgrant) on 2012-08-26
tags: added: buildd-manager
Colin Watson (cjwatson) on 2013-08-31
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant) on 2013-09-02
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2013-09-02
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers