buildd-manager failure counting is too trigger-happy when killing virtual builders

[William Grant]

lp.buildmaster.manager.assessFailureCounts is a little too trigger-happy when it determines that a virtual builder has failed:

    if builder.failure_count > job_failure_count:
        if current_job is not None:
            current_job.reset()
        if builder.failure_count >= Builder.FAILURE_THRESHOLD:
            builder.failBuilder(fail_notes)

If a virtual builder has failed, we immediately try manually ppa-resetting it. buildd-manager could do that for us before giving up.

This is closely related to bug #1039927.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r16752 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16752>.