buildd-manager failure counting is too trigger-happy when killing virtual builders
Bug #1039935 reported by
William Grant
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
lp.buildmaster.
if builder.
if current_job is not None:
if builder.
If a virtual builder has failed, we immediately try manually ppa-resetting it. buildd-manager could do that for us before giving up.
This is closely related to bug #1039927.
Related branches
lp:~cjwatson/launchpad/failure-count-reset
- William Grant (community): Approve (code)
-
Diff: 319 lines (+114/-60)3 files modifiedlib/lp/buildmaster/manager.py (+24/-7)
lib/lp/buildmaster/model/builder.py (+8/-3)
lib/lp/buildmaster/tests/test_manager.py (+82/-50)
tags: | added: canonical-losa-lp |
tags: | added: buildd-manager |
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r16752 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 16752>.