Launchpad itself

Bugs default to InformationType.PUBLIC everywhere

Bug #1031148 reported by William Grant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
William Grant

Bug Description

Bug creation pretty pervasively defaults to InformationType.PUBLIC, which is then overridden at various points if private_bugs is true, or security_related on +filebug is true, or various other situations that are fairly obscure. This makes it impossible to manually file a public bug if the project defaults to private, even if it also allows public. And it makes the code convoluted and horrid.

Related branches

lp:~wgrant/launchpad/rework-bug-default-type-0
Richard Harding (community): Approve
Diff: 161 lines (+32/-30)
6 files modified
lib/lp/bugs/browser/bugtarget.py (+7/-12)
lib/lp/bugs/interfaces/bug.py (+4/-4)
lib/lp/bugs/mail/commands.py (+12/-7)
lib/lp/bugs/model/bug.py (+4/-2)
lib/lp/bugs/xmlrpc/bug.py (+1/-1)
lib/lp/testing/factory.py (+4/-4)
lp:~wgrant/launchpad/rework-bug-default-type-1
Richard Harding (community): Approve
Diff: 544 lines (+166/-254)
5 files modified
lib/lp/bugs/browser/bugtarget.py (+117/-140)
lib/lp/bugs/browser/configure.zcml (+0/-6)
lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+5/-55)
lib/lp/bugs/templates/bugtarget-filebug-guidelines.pt (+0/-51)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+44/-2)
lp:~wgrant/launchpad/rework-bug-default-type-2
j.c.sackett (community): Approve
Diff: 369 lines (+126/-34)
10 files modified
lib/lp/bugs/browser/bugtarget.py (+21/-15)
lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+37/-8)
lib/lp/bugs/model/bug.py (+5/-9)
lib/lp/registry/interfaces/distribution.py (+6/-0)
lib/lp/registry/interfaces/product.py (+7/-1)
lib/lp/registry/model/distribution.py (+4/-0)
lib/lp/registry/model/product.py (+7/-0)
lib/lp/registry/tests/test_distribution.py (+7/-1)
lib/lp/registry/tests/test_product.py (+12/-0)
lib/lp/testing/factory.py (+20/-0)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15724 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15724) is part of this bug's fix.

tags: added: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15725 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15725) is part of this bug's fix.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Ian Booth (wallyworld)
Changed in launchpad:
status: In Progress → Fix Released
William Grant (wgrant)
Changed in launchpad:
status: Fix Released → Fix Committed
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.