Codehosting xmlrpc not handling project with trailing path
Bug #1025368 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Aaron Bentley | ||
Bug Description
Attempting to access URLs under +branch via http no longer works. This appears to be a regression introduced by r15609.
It was first seen by Gustavo Neimeyer, who reported that http://
The root cause appears to be that the XML-RPC codehosting service no longer accepts paths for project branches with additional path segments. Since Loggerhead uses this service (and supplies additional path segments), it fails to look up "+branch/project" branches.
Related branches
lp:~abentley/launchpad/broken-xmlrpc-lookup
- Deryck Hodge (community): Approve
-
Diff: 118 lines (+19/-28)4 files modifiedlib/lp/app/browser/tests/test_launchpad.py (+8/-9)
lib/lp/code/interfaces/branchlookup.py (+0/-2)
lib/lp/code/model/branchlookup.py (+8/-6)
lib/lp/code/model/tests/test_branchlookup.py (+3/-11)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| summary: |
- Launchpad not handling +branch redirects for http anymore + Codehosting xmlrpc not handling project with trailing path |
| description: | updated |
Revision history for this message
| William Grant (wgrant) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The removal of the regex should fix bug #1026231.