Sharing implies you can edit
Bug #1023427 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
The values of each share on +sharing are linked, but they are not anchors. There is no edit icon, I know I cannot change what is shared, but the text gets a pointer and underline when my pointer hovers. The old lazr Choice source widget wrapped the value in a span, then added an onclick handler to show the overlay. the action was not wired because you do not have permission to edit, but the classes that say it is a link are still on the node :(
Related branches
lp:~jcsackett/launchpad/no-write-sharing-lies
- Curtis Hovey (community): Approve (code)
-
Diff: 50 lines (+16/-1)3 files modifiedlib/canonical/launchpad/icing/css/forms.css (+6/-0)
lib/lp/app/javascript/choiceedit/choiceedit.js (+4/-0)
lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js (+6/-1)
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r15785 <http://