JS scripts assume that changing content styles work with content classes

Bug #1016890 reported by Curtis Hovey on 2012-06-23
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Unassigned

Bug Description

While investing some missing content in my development environment, I discovered that the content had the hidden or unseen classes. I pondered why the classes weren't removed since I should be able to see the content, they I noticed that the script was setting style instead. The script assumes it knows all the css rules. This decoupling/disregard for site rules make changing css dangerous when it should always be safe.

Scripts and templates setup content with classes (notably hidden), but some scripts never remove the classes when they are uneeded, instead, they change the style assuming that the class rules never change. At this moment, the bug target official tag editor and the dupe finder work by accident, not by design.

I am marking this bug high because I believe this is the root cause of two regression fixed in June.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers