picker.Picker and picker.PersonPicker need updating to current JS standards
Bug #1014874 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
The picker.Picker and picker.PersonPicker widgets are showing their age and checkered history, code wise. Given ongoing attempts to update javascript and clean up tech debt, these should both be cleaned up to use more modern YUI patterns.
Related branches
lp:~jcsackett/launchpad/cleanup-pickers-with-base-create
- Richard Harding (community): Approve
-
Diff: 1332 lines (+354/-498)5 files modifiedlib/lp/app/javascript/picker/person_picker.js (+39/-65)
lib/lp/app/javascript/picker/picker.js (+310/-424)
lib/lp/app/javascript/picker/picker_patcher.js (+3/-3)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+0/-4)
lib/lp/app/javascript/picker/tests/test_personpicker.js (+2/-2)
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: disclosure person-picker |
To post a comment you must log in.
Fixed in stable r15471 <http://