Revoking access to a branch doesn't remove subscriptions
Bug #1012448 reported by
Ian Booth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Steve Kowalik | ||
Bug Description
When an action occurs that causes users to no longer have access to a branch, their subscriptions need to be removed. This includes direct access revocation as well as when a member is removed from a team via which they had access.
Related branches
lp:~stevenk/launchpad/rbsj-generalise
- William Grant: Approve (code)
-
Diff: 537 lines (+98/-84)12 files modifiedlib/lp/bugs/model/bug.py (+5/-2)
lib/lp/bugs/model/bugtask.py (+4/-2)
lib/lp/bugs/model/tests/test_bugtask.py (+3/-3)
lib/lp/registry/configure.zcml (+5/-5)
lib/lp/registry/interfaces/sharingjob.py (+9/-8)
lib/lp/registry/model/sharingjob.py (+23/-23)
lib/lp/registry/model/teammembership.py (+4/-2)
lib/lp/registry/services/sharingservice.py (+6/-4)
lib/lp/registry/services/tests/test_sharingservice.py (+1/-1)
lib/lp/registry/tests/test_sharingjob.py (+35/-31)
lib/lp/registry/tests/test_teammembership.py (+1/-1)
lib/lp/services/config/schema-lazr.conf (+2/-2)
lp:~stevenk/launchpad/teach-rasj-about-branches
- William Grant: Approve (code)
-
Diff: 257 lines (+147/-18)2 files modifiedlib/lp/registry/model/sharingjob.py (+63/-17)
lib/lp/registry/tests/test_sharingjob.py (+84/-1)
lp:~stevenk/launchpad/fix-rasj-and-branches
- Ian Booth (community): Approve
-
Diff: 172 lines (+50/-24)3 files modifiedlib/lp/code/model/branch.py (+11/-2)
lib/lp/registry/model/sharingjob.py (+27/-22)
lib/lp/registry/tests/test_sharingjob.py (+12/-0)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Ian Booth (wallyworld) |
| tags: | added: sharing |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| assignee: | Ian Booth (wallyworld) → Steve Kowalik (stevenk) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Steve Kowalik (stevenk) wrote | #3 |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
r15539 in stable (http://