Lp sends commercial expiration emails to project that transitioned to open

[Curtis Hovey]

There is flaw in the rules for selecting which projects need a commercial expiration job. Projects that have become open will continue to set emails stating that commercial features were deactivated. There is no specific state in the db that indicates that the expired commercial subscription has been dealt with.

The rules to check Product.active to identify which projects need notification. The job that handles the expired case only deactivates proprietary projects. Open projects only have the commercial features disabled. The 30-day and 7-day expiration emails advise the maintainers to remove the proprietary licence if they wish to continue using Lp; Lp will just deactivate the commercial features.

The query to handle the expired state could omit projects without a proprietary licence, but that means the proprietary features will not be deactivated. The query could look for proprietary features and disable them. This case would ensure that proprietary features were not enabled without by circumventing the commercial subscription requirement.

What are the signs of commercial features?
* default private bugs
* default private branches
* private branches linked to series

BTW, process-job-source-groups does not know how to run the three commercial expiration jobs.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r15402 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15402>.