Archive's 'suppress_subscription_notifications' attribute is called 'commercial' in the database

Reported by Jonathan Lange on 2012-05-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Jonathan Lange

Bug Description

Archive's 'suppress_subscription_notifications' attribute is called 'commercial' in the database. This creates a sheer between the code and the database, which (mixing metaphors) causes drag to developers understanding and maintaining the system. The database column should be renamed to suppress_subscription_notifications.

Steps:
 1. Make code work with both.
 2. Rename column in the database.
 3. Remove kludges from step 1.

Related branches

lp:~jml/launchpad/remove-archive-commercial
Merged into lp:launchpad at revision 15429
Stuart Bishop: Approve on 2012-06-08
Jonathan Lange (jml) on 2012-05-30
Changed in launchpad:
status: New → In Progress
assignee: nobody → Jonathan Lange (jml)
Curtis Hovey (sinzui) on 2012-05-30
Changed in launchpad:
importance: Undecided → High
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Jonathan Lange (jml) on 2012-06-07
Changed in launchpad:
status: Fix Committed → In Progress
Jonathan Lange (jml) wrote :

Still needs db patch to rename column. However, code patch to support both column names has been QAd.

tags: added: qa-ok
removed: qa-needstesting
Ian Booth (wallyworld) on 2012-06-08
Changed in launchpad:
status: In Progress → Fix Released
William Grant (wgrant) wrote :

The code patch is deployed to everywhere that uses Archive.

Changed in launchpad:
status: Fix Released → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Jonathan Lange (jml) wrote :

Still waiting for the database patch to be deployed, and then for https://code.launchpad.net/~jml/launchpad/remove-archive-commercial/+merge/109332 to land.

Changed in launchpad:
status: Fix Committed → In Progress
Jonathan Lange (jml) on 2012-06-11
tags: added: qa-ok
removed: qa-needstesting
tags: added: qa-needstesting
removed: qa-ok
tags: added: qa-ok
removed: qa-needstesting
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Jonathan Lange (jml) wrote :

I tried QAing this. PPA pages (and lots of other pages) OOPS with:

 ProgrammingError: column archive.suppress_subscription_notifications does not exist
LINE 1: ..._cached, Archive.status, Archive.succeeded_count, Archive.su...

See https://oops.canonical.com/?oopsid=OOPS-bf04b08bab839247f5eeb9607d2c1a63

I suspect that this is because the qastaging database has not yet been updated with the new patch. I can't confirm this as I don't have psql access to the qastaging database, and the live db patch version number isn't in the footer.

William Grant (wgrant) wrote :

qastaging doesn't get patched automatically. thedac did it just now, and it all seems to work.

We really need a page listing all applied patches, since they're not applied in numerical order.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2012-06-19
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers