Launchpad itself

Archive's 'suppress_subscription_notifications' attribute is called 'commercial' in the database

Bug #1006295 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jonathan Lange

Bug Description

Archive's 'suppress_subscription_notifications' attribute is called 'commercial' in the database. This creates a sheer between the code and the database, which (mixing metaphors) causes drag to developers understanding and maintaining the system. The database column should be renamed to suppress_subscription_notifications.

Steps:
 1. Make code work with both.
 2. Rename column in the database.
 3. Remove kludges from step 1.

Related branches

lp:~jml/launchpad/archive-commercial-rename-support
William Grant: Approve (code)
Diff: 104 lines (+47/-17)
2 files modified
lib/lp/soyuz/interfaces/archive.py (+0/-8)
lib/lp/soyuz/model/archive.py (+47/-9)
lp:~jml/launchpad/db-rename-archive-commercial-to-suppress
Stuart Bishop (community): Approve (db)
Robert Collins: Pending (db) requested
Diff: 326 lines (+135/-126)
4 files modified
database/sampledata/current-dev.sql (+66/-66)
database/sampledata/current.sql (+59/-59)
database/schema/comments.sql (+1/-1)
database/schema/patch-2209-22-0.sql (+9/-0)
lp:~jml/launchpad/remove-archive-commercial
Stuart Bishop (community): Approve
Diff: 0 lines
Jonathan Lange (jml)
Changed in launchpad:
status: New → In Progress
assignee: nobody → Jonathan Lange (jml)
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Undecided → High
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15368 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15368>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Jonathan Lange (jml)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Jonathan Lange (jml) wrote :

Still needs db patch to rename column. However, code patch to support both column names has been QAd.

tags: added: qa-ok
removed: qa-needstesting
Ian Booth (wallyworld)
Changed in launchpad:
status: In Progress → Fix Released
Revision history for this message
William Grant (wgrant) wrote :

The code patch is deployed to everywhere that uses Archive.

Changed in launchpad:
status: Fix Released → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r11661 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/11661>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Jonathan Lange (jml) wrote :

Still waiting for the database patch to be deployed, and then for https://code.launchpad.net/~jml/launchpad/remove-archive-commercial/+merge/109332 to land.

Changed in launchpad:
status: Fix Committed → In Progress
Jonathan Lange (jml)
tags: added: qa-ok
removed: qa-needstesting
tags: added: qa-needstesting
removed: qa-ok
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15429 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15429>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Jonathan Lange (jml) wrote :

I tried QAing this. PPA pages (and lots of other pages) OOPS with:

 ProgrammingError: column archive.suppress_subscription_notifications does not exist
LINE 1: ..._cached, Archive.status, Archive.succeeded_count, Archive.su...

See https://oops.canonical.com/?oopsid=OOPS-bf04b08bab839247f5eeb9607d2c1a63

I suspect that this is because the qastaging database has not yet been updated with the new patch. I can't confirm this as I don't have psql access to the qastaging database, and the live db patch version number isn't in the footer.

Revision history for this message
William Grant (wgrant) wrote :

qastaging doesn't get patched automatically. thedac did it just now, and it all seems to work.

We really need a page listing all applied patches, since they're not applied in numerical order.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.