Apache configuration is necessary for tests but makes it impossible to use "make clean" safely in lxc
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
High
|
Unassigned | ||
lpsetup |
Triaged
|
High
|
Unassigned |
Bug Description
We added make clean to our parallel testing setup, and discovered that the build would fail because the /var/tmp/
To address this problem, we identified three possible solutions so far.
1) Have the tests use make inplace instead of make install, so that the Apache configuration is not installed. Unfortunately, the Apache configuration is necessary for an unknown number of tests to pass (at least some of them dealing with code hosting), so this solution would also need to fix the tests that require Apache configuration.
2) Have the branch rewriter create the directory granting the necessary permissions to everyone, following the lead of make install. We don't know how this would affect production and are afraid it might cause a security issue, so that would need to be investigated.
3) Create a new make target for cleaning that does not try to delete /var/tmp/
We are pursuing option 3 for now.
Related branches
- Gary Poster (community): Approve
-
Diff: 65 lines (+16/-5)1 file modifiedMakefile (+16/-5)
- Gary Poster (community): Approve
- Yellow Squad: Pending (code) requested
-
Diff: 12 lines (+1/-1)1 file modifiedlpsetup/templates/lp-setup-lxc-build (+1/-1)
Changed in launchpad: | |
assignee: | nobody → Brad Crittenden (bac) |
Changed in lpsetup: | |
assignee: | nobody → Brad Crittenden (bac) |
status: | New → In Progress |
importance: | Undecided → High |
Changed in lpsetup: | |
status: | In Progress → Triaged |
Changed in launchpad: | |
status: | In Progress → Triaged |
assignee: | Brad Crittenden (bac) → nobody |
Changed in lpsetup: | |
assignee: | Brad Crittenden (bac) → nobody |
Robert requests that this bug not be closed until we address solution 1, or until we create a minimum high-level bug with data on how badly tests fail without Apache config installed. He is asking for this because we are currently running branch rewrite code from earlier branches of Launchpad when we run our tests, and this is bad.