VCS import from audacity CVS failed with invalid value for commit message

Bug #487897 reported by Benjamin Drung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad CSCVS
Triaged
Low
Unassigned

Bug Description

VCS import https://code.launchpad.net/~vcs-imports/audacity/trunk from audacity CVS failed.

Traceback (most recent call last):
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/scripts/code-import-worker.py", line 61, in ?
    script.main()
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/scripts/code-import-worker.py", line 56, in main
    import_worker.run()
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/lp/codehosting/codeimport/worker.py", line 398, in run
    self._doImport()
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/lp/codehosting/codeimport/worker.py", line 476, in _doImport
    self.importToBazaar(foreign_tree, bazaar_tree)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/lp/codehosting/codeimport/worker.py", line 453, in importToBazaar
    self._runToBaz(
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/lp/codehosting/codeimport/worker.py", line 471, in _runToBaz
    totla.totla(config, self._logger, config.args, SCM.tree(source_dir))
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/cscvs/cmds/totla.py", line 253, in totla
    take_action(apply, revision, target_tree, strict, logger)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/cscvs/cmds/totla.py", line 285, in take_action
    target_tree.commitWithAutomaticLog(
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/lib/cscvs/bzr.py", line 175, in commitWithAutomaticLog
    revprops=revprops)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/eggs/bzr-2.0.0_lp_2-py2.4-linux-i686.egg/bzrlib/commit.py", line 375, in commit
    self.rev_id = self.builder.commit(self.message)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/eggs/bzr-2.0.0_lp_2-py2.4-linux-i686.egg/bzrlib/repository.py", line 163, in commit
    self._validate_unicode_text(message, 'commit message')
  File "/srv/importd.launchpad.net/production/launchpad-rev-8642/eggs/bzr-2.0.0_lp_2-py2.4-linux-i686.egg/bzrlib/repository.py", line 146, in _validate_unicode_text
    raise ValueError('Invalid value for %s: %r' % (context, text))
ValueError: Invalid value for commit message: u'\rMaintain track position (relative to start of tracklist) information and post resize/update events to inform "users" of changes.\r\rCreated a VisibleTrackIterator and updated TrackPanel, TrackArtist, and AudacityProject to take advantage of it.\r\rDo not read preference values during redraw of spectrum display types since it can be slow. They are now read when preferences are updated and written during termination. This required changes to TrackPanel as well since they two classes were basically using the config file as a means to pass min/max values.\r\rMoved the vruler updating code from DrawVRuler to UpdateVRuler to support the dynamic ruler sizing. This was necessary to correctly determine the needed width before actually starting to draw the vruler. On the Mac, the ruler would often draw incorrectly and on Windows you could see it draw at one size and then expand to another.\r\rSliding clips no longer slides it to the wrong track.\r\rAdded InvalidateSpectrumCache() to TrackArtist to provide consistent spectrum cache rebuilding. This helps to fix a bug where the cache of 2nd stereo track wasn\'t being invalidated.\r\rA few cases where a full refresh of the TrackPanel wasn\'t needed were change to only refresh the modified track(s).\r\rThe track title is no longer "pushed" for all tracks when the track menu is displayed.\r\rThe track minimize and close buttons are no longer "pushed" for all tracks when moving scrolling while one is pushed.\r\rThe left offset for the AdornedRuler was off by one causing the region, playback, and record indicators to not line up with the track indicator.\r\rThe vertical ruler is now right-aligned to prevent text overflowing into the track label area.\r\rWhen switching between track display types, the highlighted region in the horizontal ruler would not be aligned with the highlighted region in the tracks. This is now corrected.\r\rWhen cursoring down, scrolling no longer jumps the cursor back to the top of the window so you no longer have to keep looking from the bottom to the top.\r\rA few 1-off drawing issues were also resolved.'
Import failed:
Traceback (most recent call last):
Failure: twisted.internet.error.ProcessTerminated: A process has ended with a probable error condition: process ended with exit code 1.

Tags: cvs
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Assuming the problem is the \r, we can strip them out/convert them to \ns in cscvs I guess.

Revision history for this message
Benjamin Drung (bdrung) wrote :

audacity moved from CVS to SVN. So this bug do not affect audacity any more. Should I close this bug or leave it open as reminder to fix the \r issue?

Revision history for this message
Paul Hummer (rockstar) wrote :

It's still a bug in cscvs though.

affects: launchpad-code → launchpad-cscvs
Changed in launchpad-cscvs:
importance: Undecided → Medium
status: New → Triaged
tags: added: cvs
Changed in launchpad-cscvs:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.