pbuilder-satisfydepends breaks on comments before source package

Bug #728494 reported by Jelmer Vernooij
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
launchpad-buildd
Fix Released
Low
Colin Watson
pbuilder (Debian)
Fix Released
Unknown
pbuilder (Ubuntu)
Fix Released
Undecided
Mattia Rizzolo

Bug Description

Binary package hint: pbuilder

Comments before the source package paragraph in debian/control break pbuilder-satisfydepends. The problem is somewhere in get_source_control_field in /usr/lib/pbuilder/pbuilder-satisfydepends-funcs

Several of the GNOME packages have a comment at the top of the debian/control file indicating it is autogenerated, e.g. libgnome-keyring.

This affects the Launchpad buildds, which use pbuilder-satisfydepends to install the build dependencies before running clean after recipe builds.

Tags: recipe

Related branches

Jelmer Vernooij (jelmer)
Changed in pbuilder (Ubuntu):
status: New → Confirmed
assignee: nobody → Jelmer Vernooij (jelmer)
tags: added: recipe
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

An alternative would be to use mk-build-deps from devscripts instead, which uses Dpkg's perl module rather than sed to parse the control file.

Changed in pbuilder (Debian):
status: Unknown → New
Revision history for this message
Loïc Minier (lool) wrote :

mk-build-deps relies on equivs and is very fragile in my experience.

Which pbuilder-satisfydepends are you using? the aptitude version?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I can reproduce this with the aptitude version, but as far as I can tell -classic, -aptitude and -experimental all use the same function to get at the build dependencies.

Jelmer Vernooij (jelmer)
Changed in pbuilder (Ubuntu):
assignee: Jelmer Vernooij (jelmer) → nobody
affects: launchpad → launchpad-buildd
Changed in launchpad-buildd:
importance: High → Low
Revision history for this message
Colin Watson (cjwatson) wrote :

My branch to implement build-dependency handling using an sbuild-like algorithm using python-debian to parse the build-dependencies takes care of this; I've verified that by running the relevant code against libgnome-keyring's control file.

Changed in launchpad-buildd:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Changed in pbuilder (Debian):
status: New → Fix Committed
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: Fix Committed → Fix Released
Changed in pbuilder (Debian):
status: Fix Committed → Fix Released
Revision history for this message
Mattia Rizzolo (mapreri) wrote :

oh, well. this eventually reached ubuntu when 0.220ubuntu1 was uploaded 2015-11-24.

Changed in pbuilder (Ubuntu):
status: Confirmed → Fix Released
assignee: nobody → Mattia Rizzolo (mapreri)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.