Build managers call chroot hash "build id"

[Jeroen T. Vermeulen]

Now that we've replaced slave build ids with cookies, we still have lots of mention of "build id" in the BuildManager hierarchy. These are actually chroot tarball hashes. Especially confusing because the build cookies are also sha hashes. Would be nice to clear this up at some point.

[Julian Edwards (julian-edwards)]

Hi Jeroen, can you add some concrete examples of this please, so anyone else coming along to fix it knows what to look for.

Ta,

[Jeroen T. Vermeulen (jtv)]

Right ho. In lib/canonical/launchpad/slave.py, BuildManager.__init__ takes a buildid argument. It's documented as:

        :param buildid: Identifying string for this build.

You can see XMLRPCBuildDSlave.xmlrpc_build passing chrootsum as the value for that parameter. BuildManager stores the value in self._buildid, which is then used when calling mount-chroot, umount-chroot, unpack-chroot etc. It's also used by BuildManager.initiate to name the build directory. All the derived classes I looked at also use it, mostly in reconstructing the name of that build directory.

I think the code would be clearer if we renamed BuildManager._buildid to _chrootsum.

[Julian Edwards (julian-edwards)]

lib/canonical/launchpad/slave.py should be lib/canonical/buildd/slave.py I guess :)

[William Grant (wgrant)]

They're not chroot tarball hashes. They're the build ID, known as the build cookie on the master side. Build ID is fine.