launchpad-buildd

Use os.SEEK_END when migrating to python2.5

Bug #239213 reported by Celso Providelo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpad-buildd
Fix Released
Low
Jelmer Vernooij

Bug Description

There is a locally defined constant in slave.py because python2.4 'posixfile' module is deprecated. Once we migrate to python2.5 it can be replaced by using os.SEEK_END.

Tags: tech-debt

Related branches

lp:~jelmer/launchpad-buildd/remove-seek_end-constant
Graham Binns (community): Approve (code)
Diff: 45 lines (+5/-8)
2 files modified
debian/changelog (+3/-1)
lpbuildd/slave.py (+2/-7)
Revision history for this message
Diogo Matsubara (matsubara) wrote :

What's the constant?

Changed in launchpad-buildd:
status: New → Incomplete
Revision history for this message
Celso Providelo (cprov) wrote :

There are all defined as 2, buildd.slave.SEEK_END, posixfile.SEEK_END and os.SEEK_END, but it doesn't really matter, right ? Once we get python2.5 we should simply remove the local definition and use os.SEEK_END instead.

Celso Providelo (cprov)
Changed in launchpad-buildd:
status: Incomplete → Confirmed
Celso Providelo (cprov)
Changed in launchpad-buildd:
importance: Undecided → Low
status: Confirmed → Triaged
Jelmer Vernooij (jelmer)
Changed in launchpad-buildd:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer)
Changed in launchpad-buildd:
status: In Progress → Fix Committed
Revision history for this message
Adam Conrad (adconrad) wrote :

This was rolled out to production with version 110.

Changed in launchpad-buildd:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.