Need a way to pass ARGs to OCI image builds
Bug #1892351 reported by
Tom Haddon
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Thiago F. Pappacena | ||
| launchpad-buildd |
Fix Released
|
High
|
Thiago F. Pappacena | ||
Bug Description
Currently there's no way to pass arguments to OCI image builds. We use them extensively, and up til now have been populating them by running a Makefile target. This allows us to specify a default but override if we want to fairly easily. We could set defaults in the Dockerfile itself, but this would mean duplication with the Makefile.
Related branches
~pappacena/launchpad-buildd:oci-build-arg
- Colin Watson (community): Approve
-
Diff: 161 lines (+71/-2)5 files modifiedREADME (+28/-0)
lpbuildd/oci.py (+6/-0)
lpbuildd/target/build_oci.py (+11/-0)
lpbuildd/target/tests/test_build_oci.py (+21/-0)
lpbuildd/tests/test_oci.py (+5/-2)
~pappacena/launchpad:ocirecipe-args
- Colin Watson (community): Approve
-
Diff: 320 lines (+90/-11)8 files modifiedlib/lp/oci/interfaces/ocirecipe.py (+10/-1)
lib/lp/oci/model/ocirecipe.py (+17/-3)
lib/lp/oci/model/ocirecipebuildbehaviour.py (+2/-1)
lib/lp/oci/tests/test_ocirecipe.py (+44/-2)
lib/lp/oci/tests/test_ocirecipebuildbehaviour.py (+3/-0)
lib/lp/registry/interfaces/ociproject.py (+9/-1)
lib/lp/registry/model/ociproject.py (+2/-1)
lib/lp/testing/factory.py (+3/-2)
~pappacena/launchpad:db-ocirecipe-args
- William Grant: Approve (db)
- Colin Watson (community): Approve (db)
-
Diff: 16 lines (+10/-0)1 file modifieddatabase/schema/patch-2210-20-1.sql (+10/-0)
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: feature lp-oci |
Revision history for this message
| Stuart Bishop (stub) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Thiago F. Pappacena (pappacena) |
Revision history for this message
| Kristian Glass (doismellburning) wrote | #2 |
| Changed in launchpad-buildd: | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| assignee: | nobody → Thiago F. Pappacena (pappacena) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Changed in launchpad-buildd: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Barry Price (barryprice) wrote | #3 |
To post a comment you must log in.
Programmatic arguments would be nice, allowing arguments such as:
- formatted 'git describe' of the branch
- formatted current timestamp
This allows us to continue attaching useful build-time labels, such as the standard ones defined at http://