API option for automatic error reporting in snapcraft builds

Bug #1770663 reported by Evan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpad-buildd
Expired
Undecided
Unassigned

Bug Description

Snapcraft has the SNAPCRAFT_SEND_ERROR_DATA environment variable for automatic reporting to Sentry. We should allow this to be set to y by build.snapcraft.io for the snap builds it triggers since these are from public repos.

See also https://github.com/canonical-websites/build.snapcraft.io/issues/1093

Revision history for this message
Colin Watson (cjwatson) wrote :

We'll consider this. It feels kind of weird to me (we have nothing else in Launchpad that reports to Sentry, and much less anything that reports errors to an error-collection instance outside Canonical), but I don't have a concrete objection. However, there are some difficulties that come immediately to mind:

 * I may need to discuss this with legal as part of my upcoming discussions with them about GDPR compliance, since sentry.io appears to be hosted outside the EU. The discussion would be easier if we could configure snapcraft to submit to our own Sentry instance; I know that we have at least one in the company, although I don't know if any are public.

 * Does snapcraft honour http_proxy/https_proxy (and in particular an authenticated proxy) when submitting reports to Sentry? It's using requests, so it shouldn't be too terrible, but it's worth checking since there isn't going to be any other way to get HTTP out of a builder.

 * What's supposed to take care of installing python3-raven? I can understand snapcraft not wanting to have a hard dependency on it, but it doesn't even recommend or suggest it, and it's a sort of weird implementation detail for launchpad-buildd to deal with. (We'd need to do it only when installing snapcraft as a .deb, for instance, since it's in the snap.)

 * Is there any particular reason why build.snapcraft.io should need to explicitly request this, as opposed to simply doing it in launchpad-buildd for all public builds? Leaving aside the concerns above for a moment, I don't see a principled reason why we would do this for builds requested by BSI but not for other public snap builds, and making it be controllable from BSI adds what seems like unnecessary complexity.

Changed in launchpad-buildd:
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for launchpad-buildd because there has been no activity for 60 days.]

Changed in launchpad-buildd:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.