Propagate hostname to lxd container
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
launchpad-buildd |
Fix Released
|
High
|
Colin Watson |
Bug Description
As discussed on IRC, rather that giving the lxd container a generic hostname of "lp-$series-$arch", it should get a hostname based on (or exactly the same as) the host running lp-buildd.
Tail end of the IRC discussion:
07:09 < infinity> If the container has an /etc/hosts entry for lcy01-amd64-
07:09 < cjwatson> Oh, if it points to the container, I see
07:09 < cjwatson> Right, that makes sense
07:10 < infinity> That only matters if the container wants to talk to the host or vice-versa, both of which are things we explicitly don't want anyway.
07:10 < cjwatson> Yeah
07:10 < cjwatson> Can I have a bug? It's a bit fiddly because we probably need to do hostname --fqdn or something to work out what to use
07:11 < cjwatson> I can sort it out, just want a reminder
If there's some lxdish reason why it has a conniption if the host and container match (I can't see why, but hey, it could be), just prepending a subdomain of "lxd" or similar would make sense to me (ie: lxd.lcy01-
Related branches
- William Grant: Approve (code)
-
Diff: 129 lines (+39/-5)3 files modifieddebian/changelog (+7/-0)
lpbuildd/target/lxd.py (+6/-2)
lpbuildd/target/tests/test_lxd.py (+26/-3)
description: | updated |
Changed in launchpad-buildd: | |
assignee: | nobody → Colin Watson (cjwatson) |
importance: | Undecided → High |
status: | New → In Progress |
Changed in launchpad-buildd: | |
status: | In Progress → Fix Committed |
Fixed in launchpad-buildd 162, now on production.