Builder doesn't pull submodules

Bug #1694413 reported by Adnane Belmadiaf on 2017-05-30
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
launchpad-buildd
High
Colin Watson

Bug Description

I do have a snap that needs to pull a git submodule, but the builder only run git clone instead of git clone --recursive which makes the build to fail.

Related branches

Colin Watson (cjwatson) on 2017-05-31
Changed in launchpad-buildd:
status: New → In Progress
assignee: nobody → Colin Watson (cjwatson)
importance: Undecided → High
Petr (benapetr) wrote :

This bug makes build.snapcraft.io essentially useless for large projects.

Colin Watson (cjwatson) wrote :

It's not necessary to comment further here about the urgency of this bug; I've already written a fix and it is just pending review.

Petr (benapetr) wrote :

Hello Colin,

That was more than 1 month ago, does it always take this long to review 1 line patch?

That rather depends on reviewer availability, but I've done a bit of
nagging.

Colin Watson (cjwatson) on 2017-07-17
Changed in launchpad-buildd:
status: In Progress → Fix Committed
Petr (benapetr) wrote :

Hmm, it still doesn't work via build.snapcraft.io

But when I do git clone my-rep --recursive, enter it and then execute "snapcraft" it builds just fine with no errors.

Is that problem with my repo or with build.snapcraft.io?

The repository in question is: https://github.com/huggle/huggle3-qt-lx

Petr (benapetr) wrote :

On build.snapcraft.io I see this:

To debug this build:

sudo snap install lxd # if you don’t have LXD already
sudo snap install --classic --edge snapcraft # if you don’t have snapcraft already

git clone https://github.com/huggle/huggle3-qt-lx
cd huggle3-qt-lx
snapcraft cleanbuild --debug

When I do this, it won't work, but assuming that it does --recursive, when I execute:

git clone https://github.com/huggle/huggle3-qt-lx --recursive
cd huggle3-qt-lx
snapcraft cleanbuild --debug

It builds with no issues

Colin Watson (cjwatson) wrote :

I haven't yet rolled out this fix to our builder farm, so you won't see its effects. "Fix Committed" just means that it's on our development branch. When I roll it out, I'll change the bug's status to "Fix Released".

Colin Watson (cjwatson) wrote :

We've rolled out this fix now.

Changed in launchpad-buildd:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers