Builder doesn't pull submodules

[Adnane Belmadiaf]

I do have a snap that needs to pull a git submodule, but the builder only run git clone instead of git clone --recursive which makes the build to fail.

[Petr (benapetr)]

This bug makes build.snapcraft.io essentially useless for large projects.

[Colin Watson (cjwatson)]

It's not necessary to comment further here about the urgency of this bug; I've already written a fix and it is just pending review.

[Petr (benapetr)]

Hello Colin,

That was more than 1 month ago, does it always take this long to review 1 line patch?

[Colin Watson (cjwatson)]

That rather depends on reviewer availability, but I've done a bit of
nagging.

[Petr (benapetr)]

Hmm, it still doesn't work via build.snapcraft.io

But when I do git clone my-rep --recursive, enter it and then execute "snapcraft" it builds just fine with no errors.

Is that problem with my repo or with build.snapcraft.io?

The repository in question is: https://github.com/huggle/huggle3-qt-lx

[Petr (benapetr)]

On build.snapcraft.io I see this:

To debug this build:

sudo snap install lxd # if you don’t have LXD already
sudo snap install --classic --edge snapcraft # if you don’t have snapcraft already

git clone https://github.com/huggle/huggle3-qt-lx
cd huggle3-qt-lx
snapcraft cleanbuild --debug

When I do this, it won't work, but assuming that it does --recursive, when I execute:

git clone https://github.com/huggle/huggle3-qt-lx --recursive
cd huggle3-qt-lx
snapcraft cleanbuild --debug

It builds with no issues

[Colin Watson (cjwatson)]

I haven't yet rolled out this fix to our builder farm, so you won't see its effects. "Fix Committed" just means that it's on our development branch. When I roll it out, I'll change the bug's status to "Fix Released".

[Colin Watson (cjwatson)]

We've rolled out this fix now.