launchpad-buildd

Add support for building snaps

Bug #1476405 reported by Colin Watson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson
launchpad-buildd
Fix Released
High
Colin Watson

Bug Description

We've been asked to add support to Launchpad for building snap packages. The current preferred tool for doing this is in ppa:snappy-dev/snapcraft-daily. This can be another build type, a little like recipes or live filesystems; it will build a snap from a Bazaar or Git branch.

Tags: feature qa-ok

Related branches

lp:~cjwatson/launchpad/db-snappy
William Grant: Approve (db)
Diff: 216 lines (+159/-0)
2 files modified
database/schema/patch-2209-69-0.sql (+140/-0)
database/schema/security.cfg (+19/-0)
lp:~cjwatson/launchpad/snap-personmerge-whitelist
William Grant: Approve (code)
Diff: 13 lines (+3/-0)
1 file modified
lib/lp/registry/personmerge.py (+3/-0)
lp:~cjwatson/launchpad/snap-basic-model
William Grant: Approve (code)
Diff: 1014 lines (+877/-1)
12 files modified
lib/lp/app/browser/configure.zcml (+6/-0)
lib/lp/app/browser/tales.py (+11/-0)
lib/lp/configure.zcml (+1/-0)
lib/lp/registry/browser/person.py (+6/-0)
lib/lp/security.py (+37/-1)
lib/lp/snappy/browser/configure.zcml (+17/-0)
lib/lp/snappy/configure.zcml (+43/-0)
lib/lp/snappy/interfaces/snap.py (+262/-0)
lib/lp/snappy/model/snap.py (+240/-0)
lib/lp/snappy/tests/test_snap.py (+225/-0)
lib/lp/testing/factory.py (+28/-0)
utilities/snakefood/lp-sfood-packages (+1/-0)
lp:~cjwatson/launchpad/snapbuild-basic-model
William Grant: Approve (code)
Diff: 1010 lines (+923/-0)
10 files modified
lib/lp/buildmaster/enums.py (+6/-0)
lib/lp/security.py (+31/-0)
lib/lp/snappy/browser/configure.zcml (+10/-0)
lib/lp/snappy/browser/snap.py (+28/-0)
lib/lp/snappy/browser/snapbuild.py (+17/-0)
lib/lp/snappy/configure.zcml (+31/-0)
lib/lp/snappy/interfaces/snapbuild.py (+161/-0)
lib/lp/snappy/model/snapbuild.py (+358/-0)
lib/lp/snappy/tests/test_snapbuild.py (+226/-0)
lib/lp/testing/factory.py (+55/-0)
lp:~cjwatson/launchpad/snap-builds
William Grant: Approve (code)
Diff: 517 lines (+375/-10)
4 files modified
lib/lp/snappy/interfaces/snap.py (+10/-0)
lib/lp/snappy/model/snap.py (+106/-7)
lib/lp/snappy/tests/test_snap.py (+255/-0)
lib/lp/testing/factory.py (+4/-3)
lp:~cjwatson/launchpad/snap-webservice
William Grant: Approve (code)
Diff: 1550 lines (+826/-132)
16 files modified
lib/lp/app/browser/launchpad.py (+2/-0)
lib/lp/app/browser/tests/test_webservice.py (+6/-0)
lib/lp/buildmaster/browser/builder.py (+8/-0)
lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py (+3/-12)
lib/lp/snappy/browser/configure.zcml (+4/-0)
lib/lp/snappy/configure.zcml (+2/-0)
lib/lp/snappy/interfaces/snap.py (+116/-33)
lib/lp/snappy/interfaces/snapbuild.py (+42/-21)
lib/lp/snappy/interfaces/webservice.py (+41/-0)
lib/lp/snappy/model/snap.py (+5/-5)
lib/lp/snappy/tests/test_snap.py (+396/-1)
lib/lp/snappy/tests/test_snapbuild.py (+179/-2)
lib/lp/soyuz/browser/tests/test_livefsbuild.py (+5/-11)
lib/lp/soyuz/tests/test_livefsbuild.py (+2/-23)
lib/lp/soyuz/tests/test_packageupload.py (+3/-24)
lib/lp/testing/__init__.py (+12/-0)
lp:~cjwatson/launchpad/snap-mail
William Grant: Approve (code)
Diff: 230 lines (+168/-0) (has conflicts)
4 files modified
lib/lp/snappy/emailtemplates/snapbuild-notification.txt (+10/-0)
lib/lp/snappy/mail/snapbuild.py (+82/-0)
lib/lp/snappy/model/snapbuild.py (+11/-0)
lib/lp/snappy/tests/test_snapbuild.py (+65/-0)
lp:~cjwatson/launchpad/snap-personmerge
William Grant: Approve (code)
Diff: 124 lines (+66/-3)
2 files modified
lib/lp/registry/personmerge.py (+22/-3)
lib/lp/registry/tests/test_personmerge.py (+44/-0)
lp:~cjwatson/launchpad-buildd/snapcraft
William Grant: Approve (code)
Diff: 573 lines (+434/-41)
9 files modified
Makefile (+1/-0)
buildd-slave.tac (+2/-0)
buildlivefs (+6/-40)
buildsnap (+157/-0)
debian/changelog (+1/-0)
debian/rules (+1/-1)
lpbuildd/snap.py (+95/-0)
lpbuildd/tests/test_snap.py (+121/-0)
lpbuildd/util.py (+50/-0)
lp:~cjwatson/launchpad/snap-build-behaviour
William Grant: Approve (code)
Diff: 648 lines (+457/-40)
10 files modified
database/schema/security.cfg (+2/-0)
lib/lp/code/model/recipebuilder.py (+4/-26)
lib/lp/code/model/tests/test_recipebuilder.py (+3/-3)
lib/lp/services/config/schema-lazr.conf (+7/-0)
lib/lp/snappy/configure.zcml (+7/-0)
lib/lp/snappy/model/snapbuildbehaviour.py (+110/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+242/-0)
lib/lp/soyuz/adapters/archivedependencies.py (+36/-11)
lib/lp/soyuz/doc/archive-dependencies.txt (+44/-0)
lib/lp/soyuz/interfaces/archive.py (+2/-0)
lp:~cjwatson/launchpad/snap-uploader
William Grant: Approve (code)
Diff: 204 lines (+158/-2)
3 files modified
lib/lp/archiveuploader/snapupload.py (+62/-0)
lib/lp/archiveuploader/tests/test_snapupload.py (+66/-0)
lib/lp/archiveuploader/uploadprocessor.py (+30/-2)
lp:~cjwatson/launchpad/snap-source-deletion
William Grant: Approve (code)
Diff: 366 lines (+180/-16)
7 files modified
lib/lp/code/model/branch.py (+9/-2)
lib/lp/code/model/gitrepository.py (+9/-2)
lib/lp/code/model/tests/test_branch.py (+21/-2)
lib/lp/code/model/tests/test_gitrepository.py (+28/-0)
lib/lp/snappy/interfaces/snap.py (+20/-0)
lib/lp/snappy/model/snap.py (+18/-0)
lib/lp/snappy/tests/test_snap.py (+75/-10)
lp:~cjwatson/launchpad/snap-basic-browser
William Grant: Approve (code)
Diff: 1103 lines (+989/-3)
9 files modified
lib/lp/app/browser/configure.zcml (+6/-0)
lib/lp/snappy/browser/configure.zcml (+43/-0)
lib/lp/snappy/browser/snap.py (+59/-0)
lib/lp/snappy/browser/snapbuild.py (+152/-2)
lib/lp/snappy/browser/tests/test_snap.py (+180/-0)
lib/lp/snappy/browser/tests/test_snapbuild.py (+246/-0)
lib/lp/snappy/model/snap.py (+2/-1)
lib/lp/snappy/templates/snap-index.pt (+96/-0)
lib/lp/snappy/templates/snapbuild-index.pt (+205/-0)
lp:~cjwatson/launchpad/snap-edit-views
William Grant: Approve (code)
Diff: 975 lines (+825/-4)
10 files modified
lib/lp/snappy/browser/configure.zcml (+21/-0)
lib/lp/snappy/browser/snap.py (+211/-1)
lib/lp/snappy/browser/tests/test_snap.py (+201/-1)
lib/lp/snappy/javascript/snap.edit.js (+36/-0)
lib/lp/snappy/javascript/tests/test_snap.edit.html (+146/-0)
lib/lp/snappy/javascript/tests/test_snap.edit.js (+80/-0)
lib/lp/snappy/templates/snap-delete.pt (+21/-0)
lib/lp/snappy/templates/snap-edit.pt (+79/-0)
lib/lp/snappy/templates/snap-index.pt (+6/-2)
lib/lp/snappy/tests/test_yuitests.py (+24/-0)
lp:~cjwatson/launchpad/snap-canonicalise-git-path
William Grant: Approve (code)
Diff: 880 lines (+447/-67)
15 files modified
lib/lp/app/templates/launchpad-widget-macros.pt (+1/-1)
lib/lp/code/browser/widgets/gitref.py (+128/-0)
lib/lp/code/browser/widgets/templates/gitref.pt (+18/-0)
lib/lp/code/browser/widgets/tests/test_gitrefwidget.py (+199/-0)
lib/lp/snappy/browser/snap.py (+10/-14)
lib/lp/snappy/interfaces/snap.py (+14/-7)
lib/lp/snappy/javascript/snap.edit.js (+2/-2)
lib/lp/snappy/javascript/tests/test_snap.edit.html (+6/-6)
lib/lp/snappy/javascript/tests/test_snap.edit.js (+10/-8)
lib/lp/snappy/model/snap.py (+26/-9)
lib/lp/snappy/model/snapbuildbehaviour.py (+5/-2)
lib/lp/snappy/templates/snap-edit.pt (+1/-4)
lib/lp/snappy/tests/test_snap.py (+10/-6)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+16/-1)
lib/lp/testing/factory.py (+1/-7)
lp:~cjwatson/launchpad/snap-listings
William Grant: Approve (code)
Diff: 1446 lines (+849/-61)
29 files modified
lib/lp/code/browser/branch.py (+7/-3)
lib/lp/code/browser/gitref.py (+2/-1)
lib/lp/code/browser/gitrepository.py (+3/-1)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/gitrepository.py (+2/-1)
lib/lp/code/model/tests/test_hasrecipes.py (+2/-2)
lib/lp/code/templates/branch-index.pt (+2/-2)
lib/lp/code/templates/gitref-index.pt (+1/-0)
lib/lp/code/templates/gitrepository-index.pt (+8/-0)
lib/lp/registry/browser/person.py (+8/-2)
lib/lp/registry/browser/product.py (+4/-3)
lib/lp/registry/browser/team.py (+5/-2)
lib/lp/registry/model/product.py (+0/-2)
lib/lp/registry/personmerge.py (+2/-2)
lib/lp/registry/templates/product-index.pt (+4/-0)
lib/lp/registry/tests/test_personmerge.py (+2/-2)
lib/lp/snappy/browser/configure.zcml (+37/-0)
lib/lp/snappy/browser/hassnaps.py (+60/-0)
lib/lp/snappy/browser/snap.py (+0/-9)
lib/lp/snappy/browser/snaplisting.py (+84/-0)
lib/lp/snappy/browser/tests/test_snaplisting.py (+248/-0)
lib/lp/snappy/interfaces/snap.py (+50/-2)
lib/lp/snappy/model/snap.py (+129/-1)
lib/lp/snappy/model/snapbuild.py (+11/-1)
lib/lp/snappy/templates/snap-index.pt (+2/-1)
lib/lp/snappy/templates/snap-listing.pt (+40/-0)
lib/lp/snappy/templates/snap-macros.pt (+29/-0)
lib/lp/snappy/tests/test_snap.py (+94/-18)
lib/lp/soyuz/templates/person-portlet-ppas.pt (+11/-4)
lp:~cjwatson/launchpad/snap-add-view
William Grant: Approve (code)
Diff: 432 lines (+251/-15)
9 files modified
lib/lp/code/browser/branch.py (+4/-4)
lib/lp/code/browser/gitref.py (+6/-3)
lib/lp/snappy/browser/configure.zcml (+12/-0)
lib/lp/snappy/browser/hassnaps.py (+8/-0)
lib/lp/snappy/browser/snap.py (+64/-7)
lib/lp/snappy/browser/tests/test_snap.py (+110/-1)
lib/lp/snappy/templates/snap-macros.pt (+6/-0)
lib/lp/snappy/templates/snap-new.pt (+40/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+1/-0)
lp:~cjwatson/launchpad/snap-requestBuild-ui
William Grant: Approve (code)
Diff: 961 lines (+755/-10)
13 files modified
lib/lp/snappy/browser/configure.zcml (+9/-1)
lib/lp/snappy/browser/snap.py (+124/-3)
lib/lp/snappy/browser/tests/test_snap.py (+120/-0)
lib/lp/snappy/browser/widgets/snaparchive.py (+133/-0)
lib/lp/snappy/browser/widgets/templates/snaparchive.pt (+32/-0)
lib/lp/snappy/browser/widgets/tests/test_snaparchivewidget.py (+245/-0)
lib/lp/snappy/configure.zcml (+1/-0)
lib/lp/snappy/interfaces/snap.py (+6/-0)
lib/lp/snappy/model/snap.py (+3/-6)
lib/lp/snappy/templates/snap-index.pt (+4/-0)
lib/lp/snappy/templates/snap-request-builds.pt (+29/-0)
lib/lp/snappy/vocabularies.py (+31/-0)
lib/lp/snappy/vocabularies.zcml (+18/-0)
Colin Watson (cjwatson)
tags: added: feature
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Changed in launchpad-buildd:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17645 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17645) by a commit, but not testable.

Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
tags: added: qa-untestable
Changed in launchpad:
status: Triaged → Fix Committed
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r13160 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/13160) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-untestable
Revision history for this message
Colin Watson (cjwatson) wrote :

2015-07-30 15:09:32,910 INFO 2209-69-0 applied just now in 0.6 seconds

tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad-buildd:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17659 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17659) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17662 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17662) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17663 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17663) is part of this bug's fix.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17664 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17664) is part of this bug's fix.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17665 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17665) is part of this bug's fix.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17666 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17666) is part of this bug's fix.

Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17675 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17675) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17677 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17677) is part of this bug's fix.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17678 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17678) is part of this bug's fix.

Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: Fix Committed → Fix Released
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17685 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17685) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

Oh this is going to be amazing. Thank you!

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17715 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17715) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17723 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17723) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17745 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17745) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17747 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17747) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17749 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17749>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.