codebrowse broken by dirstate-tags

[Scott James Remnant (Canonical)]

Displays "500 Internal Error" on a 0.16 branch with the dirstate-tags format, e.g.

http://codebrowse.launchpad.net/~keybuk/upstart/main/changes

[Michael Hudson-Doyle (mwhudson)]

It's working again now (presumably a restart fixed it), and I've not been able to reproduce this.

For reference, the traceback was:

INF [20070606-08:56:30.637] cherrypy.msg: HTTP: Traceback (most recent call last):
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/CherryPy-2.2.1-py2.4.egg/cherrypy/_cphttptools.py", line 105, in _run
    self.main()
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/CherryPy-2.2.1-py2.4.egg/cherrypy/_cphttptools.py", line 254, in main
    body = page_handler(*virtual_path, **self.params)
  File "/srv/codebrowse.launchpad.net/launchpad-loggerhead/loggerhead/util.py", line 344, in _f
    out = f(*a, **kw)
  File "<string>", line 3, in default
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/TurboGears-1.0.1-py2.4.egg/turbogears/controllers.py", line 334, in expose
    output = database.run_with_transaction(
  File "<string>", line 5, in run_with_transaction
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/TurboGears-1.0.1-py2.4.egg/turbogears/database.py", line 302, in so_rwt
    retval = func(*args, **kw)
  File "<string>", line 5, in _expose
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/TurboGears-1.0.1-py2.4.egg/turbogears/controllers.py", line 351, in <lambda>
    mapping, fragment, args, kw)))
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/TurboGears-1.0.1-py2.4.egg/turbogears/controllers.py", line 378, in _execute_func
    output = errorhandling.try_call(func, *args, **kw)
  File "/srv/codebrowse.launchpad.net/turbogears/lib/python2.4/site-packages/TurboGears-1.0.1-py2.4.egg/turbogears/errorhandling.py", line 73, in try_call
    return func(self, *args, **kw)
  File "/srv/codebrowse.launchpad.net/launchpad-loggerhead/loggerhead/controllers/changelog_ui.py", line 40, in default
    h = self._branch.get_history()
  File "/srv/codebrowse.launchpad.net/launchpad-loggerhead/loggerhead/util.py", line 334, in locked
    return unbound(self, *args, **kw)
  File "/srv/codebrowse.launchpad.net/launchpad-loggerhead/loggerhead/branchview.py", line 140, in get_history
    if (self._history is None) or self._history.out_of_date():
  File "/srv/codebrowse.launchpad.net/launchpad-loggerhead/loggerhead/util.py", line 334, in locked
    return unbound(self, *args, **kw)
  File "/srv/codebrowse.launchpad.net/launchpad-loggerhead/loggerhead/history.py", line 232, in out_of_date
    if self._branch.revision_history()[-1] != self._last_revid:
  File "<string>", line 4, in revision_history_read_locked
  File "/usr/lib/python2.4/site-packages/bzrlib/branch.py", line 436, in revision_history
    history = self._gen_revision_history()
  File "/usr/lib/python2.4/site-packages/bzrlib/branch.py", line 1395, in _gen_revision_history
    history = self.control_files.get('revision-history').read().split('\n')
  File "<string>", line 4, in get_read_locked
  File "/usr/lib/python2.4/site-packages/bzrlib/lockable_files.py", line 179, in get
    return self._transport.get(relpath)
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/local.py", line 144, in get
    sel...

[Michael Hudson-Doyle (mwhudson)]

Basically, the problem is that loggerhead keeps branches around for too long. It would make sense to keep them open for only the duration of one request, but that will require a bit of restructuring in loggerhead...

[Tim Penhey (thumper)]

There was another occurrence of this https://answers.launchpad.net/launchpad-bazaar/+question/8291.

[Michael Hudson-Doyle (mwhudson)]

This wasn't so hard to fix in the end, see revision 152 of my testing branch.

[Michael Hudson-Doyle (mwhudson)]

The fix is deployed now, but of course this involved restarting loggerhead which will have fixed the mentioned branches anyway...