Need logrotation

[Peter Sabaini]

[Impact]
Users of the radosgw package don't get logrotation, resulting in ever growing log files (esp with debug enabled) and exhausted filesystem space.

[Test Case]
Install ceph and radosgw using charms
/var/log/ceph/radosgw.log is never log rotated

[Regression Potential]
The fix for this is to move log rotation from the ceph package to the ceph-common package, which is used by all ceph daemon binary packages, covering the radosgw package as well; minimal risk.

[Original Bug Report]
The ceph-radosgw charm appears not to set up log rotation for /var/log/ceph/radosgw.log but probably should as this will grow indef. over time

Using
lp:~openstack-charmers/charms/trusty/ceph-radosgw/next;revno=86

[Adam Collard (adam-collard)]

The ceph package installs a /etc/logrotate.d/ceph file which would (if co-located with radosgw) rotate the files: https://pastebin.canonical.com/172231/

For the ceph-radosgw case, the ceph package is not installed (it's just a client after all) but nevertheless logging is configured to go to /var/log/ceph/radosgw.log - without any corresponding logrotate.d entry

[Adam Collard (adam-collard)]

⟫ ls -l debian/radosgw.logrotate
lrwxrwxrwx 1 acollard acollard 25 Mar 30 2016 debian/radosgw.logrotate -> ../src/rgw/logrotate.conf

Looks like there's a dangling symlink left in debian/ - ../src/logrotate.conf would be a better target (and includes support for rgw)

[Adam Collard (adam-collard)]

Attaching .dsc and .debian.tar.xz of the fixed package - unfortunately debdiff failed me.

The intended change is to make radosgw.logrotate point to the actual logrotate config shipped in upstream.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ceph - 10.2.5-0ubuntu2

---------------
ceph (10.2.5-0ubuntu2) zesty; urgency=medium

  * d/rules: Install upstream provided systemd targets and ensure they
    are enabled and started on install to ensure that integrations aligned
    to upstream packaging work with Ubuntu packages (LP: #1646583).
  * d/rules,d/p/powerpc_libatomic.patch: Ensure linking with -latomic,
    resolving FTBFS on powerpc architecture.

 -- James Page <email address hidden> Tue, 17 Jan 2017 11:10:40 +0000

[Brian Murray (brian-murray)]

Hello Peter, or anyone else affected,

Accepted ceph into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ceph/10.2.5-0ubuntu0.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Łukasz Zemczak (sil2100)]

Hello Peter, or anyone else affected,

Accepted ceph into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ceph/10.2.5-0ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[James Page (james-page)]

Logrotate configuration installed correctly on upgrade to -proposed packages for xenial and yakkety; radosgw logs rotated correctly.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ceph - 10.2.5-0ubuntu0.16.04.1

---------------
ceph (10.2.5-0ubuntu0.16.04.1) xenial; urgency=medium

  * New upstream stable release (LP: #1649856):
    - d/p/32bit-ftbfs.patch: Drop, no longer required.
    - d/p/*: Refresh.
    - d/ceph-common.install: Switch to RSA keys for drop.ceph.com.
  * d/rules: Install upstream provided systemd targets and ensure they
    are enabled and started on install to ensure that integrations aligned
    to upstream packaging work with Ubuntu packages (LP: #1646583).
  * d/ceph.*,d/*.logrotate: Install logrotate configuration
    in ceph-common, ensuring that all daemons get log rotation on
    log files, deal with removal of logrotate configuration in
    ceph for upgrades (LP: #1609866).

 -- James Page <email address hidden> Wed, 18 Jan 2017 13:59:57 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for ceph has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ceph - 10.2.5-0ubuntu0.16.10.1

---------------
ceph (10.2.5-0ubuntu0.16.10.1) yakkety; urgency=medium

  * New upstream stable release (LP: #1649856):
    - d/p/32bit-ftbfs.patch: Drop, no longer required.
    - d/p/*: Refresh.
    - d/ceph-common.install: Switch to RSA keys for drop.ceph.com.
  * d/rules: Install upstream provided systemd targets and ensure they
    are enabled and started on install to ensure that integrations aligned
    to upstream packaging work with Ubuntu packages (LP: #1646583).
  * d/ceph.{postinst,preinst,postrm}: Ensure that ceph logrotate
    configuration is purged on upgrade from pre-yakkety installs
    (LP: #1635844).
  * d/ceph-base.*,d/*.logrotate: Install logrotate configuration
    in ceph-common, ensuring that all daemons get log rotation on
    log files, deal with removal of logrotate configuration in
    ceph-base for upgrades (LP: #1609866).

 -- James Page <email address hidden> Wed, 18 Jan 2017 11:39:04 +0000