Auto-approve new installations in package activities doesn't work with upgrades

[Andreas Hasenack]

It's not working because an upgrade is basically a removal and a installation. Then the check in the code that makes sure there are no removals is tricked into thinking an upgrade is or has a removal, and the automatic approval doesn't happen.

Here are some logs from a client. The activity was to upgrade libsasl2-modules, which depends on libsasl2:
==> /var/log/landscape/package-changer.log <==
2010-03-15 18:04:35,843 INFO [MainThread] may_complement_changes called
2010-03-15 18:04:35,843 INFO [MainThread] policy = 1
2010-03-15 18:04:35,844 INFO [MainThread] result.installs=[284239]
2010-03-15 18:04:35,844 INFO [MainThread] result.removals=[115439]
2010-03-15 18:04:35,844 INFO [MainThread] policy is ALLOW_INSTALLS
2010-03-15 18:04:35,844 INFO [MainThread] returning false

landscape_staging_package=> select id,name,version from package where id in (115439,284239);
   id | name | version
--------+----------+---------------------------
 115439 | libsasl2 | 2.1.19.dfsg1-0.1ubuntu3
 284239 | libsasl2 | 2.1.19.dfsg1-0.1ubuntu3.1
(2 rows)

We can see that there is a removal, but in this case it's part of an upgrade. See also the screenshot at http://launchpadlibrarian.net/40966710/Activity%20-%20Landscape%20-%20Mozilla%20Firefox_002.png

[🤖 Landscape Builder (landscape-builder)]

This bug has not seen any activity in the last 6 months, so it is being automatically closed.

If you are still experiencing this issue, please feel free to re-open.

Landscape Team