The package reporter should check the APT sources.list modification time

[Free Ekanayaka]

When deciding whether to run the smart update wrapper or not, the
package reporter should check the modification time of the
/etc/apt/sources.list file. If it was modified in the last 30 minutes,
the reporter should force a smart update run (note that 30 minutes in
exactly the package reporter run interval).

This is a general user-experience improvement (shorter delay between the
change and the report), but it's especially important at the end of
release upgrades, where the sources.list gets modified and smart update
should be run as soon as possible, either by the package-reporter
started as consequence of the landscape-client service being updated and
restarted or by the release-upgrader process itself once it ends
(sometimes a race happens and one of the two wins).

 affects landscape-client
 status inprogress
 importance medium
 assignee free.ekanayaka
 milestone 1.4.3

[Free Ekanayaka (free.ekanayaka)]

This ready to be reviewed.

[Kevin McDermott (bigkevmcd)]

Small clear changes, +1

[Thomas Herve (therve)]

[1] It looks like test_wb_apt_sources_have_changed is present 2 times.

+1!

[Andreas Hasenack (ahasenack)]

Just a FYI, there is another new behaviour introduced here. A smart update will be forced every time landscape-client is restarted after a sources.list file is modified, until (PackageMonitor.run_interval)seconds go by.

[Andreas Hasenack (ahasenack)]

Also, the time difference can be negative (think the file being modified while the clock is wrongly set to the future, then it's fixed and landscape-client runs). The impact is that smart update will be forcibly run with the package reporter for longer than anticipated.

[Andreas Hasenack (ahasenack)]

Confirmed in staging.