Comment 6 for bug 397480

Christopher Armstrong (radix) wrote :

[1]
+ arch = self._facade.get_arch()
+ if not isinstance(arch, str):
+ logging.warning(warning % "unknown dpkg architecture")
+ return None

This strikes me as a strange check and warning. Do you know in which cases the arch is not a str? does get_arch return None sometimes? Is it ever something else? Maybe the check could be something more explicit.

[2]
in watchdog.py

- We do this to avoid any problems when landscape-client is invoked from its
+ In particular unsert all variables beginning with DEBIAN_ or DEBCONF_,

"unsert" should be "unset"

[3] I don't see tests for the new code that sets HOME, USER, and LOGNAME in the environment in the watchdog.