landscape.lib.fetch doesn't define timeout

Bug #349737 reported by Thomas Herve on 2009-03-27
14
Affects Status Importance Assigned to Milestone
Landscape Client
High
Thomas Herve
Landscape Server
High
Thomas Herve
landscape-client (Ubuntu)
Undecided
Unassigned

Bug Description

It uses curl underneath, but doesn't set any timeout, so it can hang forever waiting for a response.

Thomas Herve (therve) on 2009-03-27
Changed in landscape-client:
assignee: nobody → therve
importance: Undecided → High
Changed in landscape:
importance: Undecided → High
milestone: none → mountainview-pre-8
assignee: nobody → therve
Thomas Herve (therve) on 2009-03-27
Changed in landscape:
status: New → In Progress
Changed in landscape-client:
status: New → In Progress
Gustavo Niemeyer (niemeyer) wrote :

One thing for us to keep in mind when introducing the timeout is that we have to put a timeout high-enough to allow for long payloads to be sent to the server. We should probably base the timeout on the server-side timeout, so maybe 5 minutes or more.

Thomas Herve (therve) wrote :

This is ready to review in the attached branch. I just defined the 2 timeouts and check the options in the tests.

Gustavo Niemeyer (niemeyer) wrote :

I've missed that there was a branch up for review, and that you're already using 5 minutes. +1!

Jamu Kakar (jkakar) wrote :

Nice, +1.

tags: removed: review
Thomas Herve (therve) wrote :

Thanks, merged in r93.

Changed in landscape:
status: In Progress → Fix Committed
Changed in landscape-client:
status: In Progress → Fix Committed
Changed in landscape-client:
milestone: none → 1.0.29
Changed in landscape:
status: Fix Committed → Fix Released
Changed in landscape:
milestone: mountainview-pre-8 → mountainview
status: Fix Released → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 1.0.29-0ubuntu0.9.04.0

---------------
landscape-client (1.0.29-0ubuntu0.9.04.0) jaunty; urgency=low

  * New upstream bugfix release (LP: #358744)
    - Add a timeout to HTTP operations to avoid hanging (LP: #349737)
    - Clean up environment variables on startup to avoid propagating
      variables that will corrupt package installation (LP: #348681)
    - Clean up FDs on startup for the same reason (LP: #352458)
    - Catch and handle certain errors from smart (such as invalid package
      data) to avoid "stuck" Landscape activities (LP: #268745)
    - Don't print warnings meant for developers to the console (LP: #336669)

 -- Christopher Armstrong <email address hidden> Thu, 09 Apr 2009 17:09:50 -0400

Changed in landscape-client (Ubuntu):
status: New → Fix Released
Changed in landscape:
status: Fix Committed → Fix Released
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers