| 2009-03-25 21:27:16 |
Andreas Hasenack |
bug |
|
|
added bug |
| 2009-03-25 21:28:12 |
Andreas Hasenack |
landscape: bugtargetdisplayname |
Landscape |
Landscape Client |
|
| 2009-03-25 21:28:12 |
Andreas Hasenack |
landscape: bugtargetname |
landscape |
landscape-client |
|
| 2009-03-25 21:28:12 |
Andreas Hasenack |
landscape: statusexplanation |
|
|
|
| 2009-03-25 21:28:12 |
Andreas Hasenack |
landscape: title |
Bug #348681 in Landscape: "landscape-client should sanitize environment and close file descriptors on startup" |
Bug #348681 in Landscape Client: "landscape-client should sanitize environment and close file descriptors on startup" |
|
| 2009-03-25 21:29:05 |
Andreas Hasenack |
who_made_private |
ahasenack |
|
|
| 2009-03-25 21:29:21 |
Andreas Hasenack |
landscape-client: importance |
Undecided |
High |
|
| 2009-03-25 21:29:49 |
Andreas Hasenack |
bug |
|
|
assigned to landscape |
| 2009-03-25 21:30:06 |
Andreas Hasenack |
landscape: importance |
Undecided |
High |
|
| 2009-03-25 21:30:06 |
Andreas Hasenack |
landscape: statusexplanation |
|
|
|
| 2009-03-25 21:30:06 |
Andreas Hasenack |
landscape: milestone |
|
mountainview-pre-8 |
|
| 2009-03-26 18:39:56 |
Andreas Hasenack |
description |
We came across a situation in ls3 where the parent landscape-client environment had a DEBIAN_HAS_FRONTEND variable set. This came from a previous upgrade where landscape-client itself was upgraded and restarted, inheriting this variable from dpkg.
landscape-client should clean these variables on startup as they can mess up with subsequent package activities. In the ls3 case, dpkg got stuck. This was suggested:
<cjwatson> andreas: I think I would probably recommend iterating over the environment and unsetting anything that starts with DEBIAN_ or DEBCONF_
<cjwatson> if you want to be more selective, then DEBCONF_* plus DEBIAN_FRONTEND, DEBIAN_HAS_FRONTEND, DEBIAN_PRIORITY is a complete list
It was also mentioned that landscape-client should close the file descriptors it inherits. During normal startup it's not an issue, but it can become one when landscape-client upgrades itself.
<cjwatson> niemeyer: if a process inherits the fd that's for writing to debconf and doesn't close it on startup, then debconf will hang when it's trying to shut down
<cjwatson> niemeyer: so this isn't for future package installations using smart, it's something that landscape-client needs to do on startup if it's called from a postinst |
We came across a situation in ls3 where the parent landscape-client environment had a DEBIAN_HAS_FRONTEND variable set. This came from a previous upgrade where landscape-client itself was upgraded and restarted, inheriting this variable from dpkg.
landscape-client should clean these variables on startup as they can mess up with subsequent package activities. In the ls3 case, dpkg got stuck. This was suggested:
<cjwatson> andreas: I think I would probably recommend iterating over the environment and unsetting anything that starts with DEBIAN_ or DEBCONF_
<cjwatson> if you want to be more selective, then DEBCONF_* plus DEBIAN_FRONTEND, DEBIAN_HAS_FRONTEND, DEBIAN_PRIORITY is a complete list
It was also mentioned that landscape-client should close the file descriptors it inherits. During normal startup it's not an issue, but it can become one when landscape-client upgrades itself.
<cjwatson> niemeyer: if a process inherits the fd that's for writing to debconf and doesn't close it on startup, then debconf will hang when it's trying to shut down
<cjwatson> niemeyer: so this isn't for future package installations using smart, it's something that landscape-client needs to do on startup if it's called from a postinst
Oops, and don't forget LANDSCAPE_ATTACHMENTS. Although it gets overwritten if used, I didn't check what happens if there are no attachments, i.e., if landscape-client empties it.
|
|
| 2009-03-27 17:12:39 |
Christopher Armstrong |
branch linked |
|
lp:~radix/landscape-client/clean-up-environment |
|
| 2009-03-27 17:14:18 |
Christopher Armstrong |
tags |
|
review |
|
| 2009-03-28 00:26:49 |
Jamu Kakar |
tags |
review |
|
|
| 2009-03-30 21:43:47 |
Andreas Hasenack |
landscape-client: milestone |
|
1.0.29 |
|
| 2009-03-31 15:21:06 |
Christopher Armstrong |
description |
We came across a situation in ls3 where the parent landscape-client environment had a DEBIAN_HAS_FRONTEND variable set. This came from a previous upgrade where landscape-client itself was upgraded and restarted, inheriting this variable from dpkg.
landscape-client should clean these variables on startup as they can mess up with subsequent package activities. In the ls3 case, dpkg got stuck. This was suggested:
<cjwatson> andreas: I think I would probably recommend iterating over the environment and unsetting anything that starts with DEBIAN_ or DEBCONF_
<cjwatson> if you want to be more selective, then DEBCONF_* plus DEBIAN_FRONTEND, DEBIAN_HAS_FRONTEND, DEBIAN_PRIORITY is a complete list
It was also mentioned that landscape-client should close the file descriptors it inherits. During normal startup it's not an issue, but it can become one when landscape-client upgrades itself.
<cjwatson> niemeyer: if a process inherits the fd that's for writing to debconf and doesn't close it on startup, then debconf will hang when it's trying to shut down
<cjwatson> niemeyer: so this isn't for future package installations using smart, it's something that landscape-client needs to do on startup if it's called from a postinst
Oops, and don't forget LANDSCAPE_ATTACHMENTS. Although it gets overwritten if used, I didn't check what happens if there are no attachments, i.e., if landscape-client empties it.
|
We came across a situation in ls3 where the parent landscape-client environment had a DEBIAN_HAS_FRONTEND variable set. This came from a previous upgrade where landscape-client itself was upgraded and restarted, inheriting this variable from dpkg.
landscape-client should clean these variables on startup as they can mess up with subsequent package activities. In the ls3 case, dpkg got stuck. This was suggested:
<cjwatson> andreas: I think I would probably recommend iterating over the environment and unsetting anything that starts with DEBIAN_ or DEBCONF_
<cjwatson> if you want to be more selective, then DEBCONF_* plus DEBIAN_FRONTEND, DEBIAN_HAS_FRONTEND, DEBIAN_PRIORITY is a complete list
Oops, and don't forget LANDSCAPE_ATTACHMENTS. Although it gets overwritten if used, I didn't check what happens if there are no attachments, i.e., if landscape-client empties it.
|
|
| 2009-03-31 16:25:54 |
Christopher Armstrong |
landscape-client: status |
New |
Fix Committed |
|
| 2009-03-31 16:25:54 |
Christopher Armstrong |
landscape-client: assignee |
|
radix |
|
| 2009-03-31 16:26:06 |
Christopher Armstrong |
landscape: status |
New |
Fix Committed |
|
| 2009-03-31 16:26:06 |
Christopher Armstrong |
landscape: assignee |
|
radix |
|
| 2009-04-01 19:13:51 |
Andreas Hasenack |
bug |
|
|
assigned to landscape-client (Ubuntu) |
| 2009-04-06 20:47:25 |
Brian Murray |
bug task added |
|
landscape-client (Ubuntu Jaunty) |
|
| 2009-04-06 22:53:56 |
Gabriele Monti |
attachment added |
|
landscape-client_1.0.28-0ubuntu2.9.04.0.debdiff http://launchpadlibrarian.net/24911229/landscape-client_1.0.28-0ubuntu2.9.04.0.debdiff |
|
| 2009-04-08 18:22:21 |
Andreas Hasenack |
landscape: status |
Fix Committed |
Fix Released |
|
| 2009-04-08 18:32:57 |
Andreas Hasenack |
landscape: status |
Fix Released |
Fix Committed |
|
| 2009-04-08 18:32:57 |
Andreas Hasenack |
landscape: milestone |
mountainview-pre-8 |
mountainview |
|
| 2009-04-10 01:21:44 |
Launchpad Janitor |
landscape-client (Ubuntu Jaunty): status |
New |
Fix Released |
|
| 2009-04-22 20:37:42 |
Andreas Hasenack |
landscape: status |
Fix Committed |
Fix Released |
|
| 2009-07-17 18:36:07 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/karmic/landscape-client |
|
| 2009-10-09 22:54:38 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/intrepid-proposed/landscape-client |
|
| 2009-11-17 15:27:35 |
Andreas Hasenack |
landscape-client: status |
Fix Committed |
Fix Released |
|
