landscape-config's exit status is zero in case of error

Bug #271759 reported by Andreas Hasenack
4
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
High
Free Ekanayaka

Bug Description

When landscape-config fails, its exit status is still zero:

Enable script execution? [y/N]
landscape-client is not configured, please run landscape-config.

Request a new registration for this computer now? (Y/n):
Please wait... Error occurred contacting Landscape Client. Is it running?
root@nsn2:~# echo $?
0

Another situation:
 * Starting the landscape-client daemon [ OK ]

Request a new registration for this computer now? (Y/n):
Please wait... Invalid account name or registration password.
root@nsn2:~# echo $?
0

Changed in landscape-client:
importance: Undecided → Low
Changed in landscape:
importance: Undecided → Low
milestone: none → thames-pre-8
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Having a proper exit code would help batch deployments of landscape-client.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Pushed for thames-pre-9

Changed in landscape:
milestone: thames-pre-8 → thames-pre-9
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Pushed for the final thames milestone.

Changed in landscape:
milestone: thames-pre-9 → thames
Changed in landscape:
milestone: thames → thames+1
Changed in landscape:
milestone: thames+1 → thames+2
Changed in landscape:
milestone: mountainview-pre-1 → mountainview-pre-2
Changed in landscape:
milestone: mountainview-pre-2 → mountainview-pre-3
Changed in landscape:
milestone: mountainview-pre-3 → mountainview
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Decoupling server bugs from client ones.

Changed in landscape:
status: New → Invalid
Changed in landscape-client:
milestone: none → 1.0.x
Changed in landscape-client:
milestone: 1.0.x → backlog
Changed in landscape-client:
status: New → In Progress
no longer affects: landscape
Changed in landscape-client:
assignee: nobody → Free Ekanayaka (free.ekanayaka)
milestone: backlog → 12.03.1
importance: Low → High
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Fixed in r496.

Changed in landscape-client:
status: In Progress → Fix Committed
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.