Activity log for bug #1765518

Date Who What changed Old value New value Message
2018-04-19 20:13:22 Gabriel Ramirez bug added bug
2018-04-19 20:13:49 Gabriel Ramirez description Steps to reproduce: 1) Add tag to a landscape-client, ex assgn tag 'täg 2) Go to scripts in the GUI page and attempt to execute script on that client 3) Script will attempt to run on client and will fail, GUI will show below error: [Failure instance: Traceback: <type 'exceptions.TypeError'>: Environment contains a non-string value /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:176:_handle_execute_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:292:run_script /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:306:addCallback /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:295:addCallbacks --- <exception caught here> --- /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:577:_runCallbacks /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:290:prepare_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:129:_run_script /usr/lib/python2.7/dist-packages/twisted/internet/posixbase.py:336:spawnProcess /usr/lib/python2.7/dist-packages/twisted/internet/base.py:923:_checkProcessArgs ] Above exception is generated by the client w/ LANDSCAPE_COMPUTER_TAGS w/ value being None Steps to reproduce: 1) Add tag to a landscape-client, ex assgn tag 'täg 2) Go to scripts in the GUI page and attempt to execute script on that client 3) Script will attempt to run on client and will fail, GUI will show below error: [Failure instance: Traceback: <type 'exceptions.TypeError'>: Environment contains a non-string value /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:176:_handle_execute_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:292:run_script /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:306:addCallback /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:295:addCallbacks --- <exception caught here> --- /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:577:_runCallbacks /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:290:prepare_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:129:_run_script /usr/lib/python2.7/dist-packages/twisted/internet/posixbase.py:336:spawnProcess /usr/lib/python2.7/dist-packages/twisted/internet/base.py:923:_checkProcessArgs ] Above exception is generated by the client w/ LANDSCAPE_COMPUTER_TAGS value being None
2018-04-19 20:57:21 Simon Poirier landscape: importance Undecided Low
2018-04-19 20:58:14 Simon Poirier tags low-hanging-fruit
2018-04-19 20:59:23 Simon Poirier landscape: status New Confirmed
2018-04-19 20:59:28 Simon Poirier landscape: status Confirmed Triaged
2018-07-13 15:00:18 Dave Jones landscape: assignee Dave Jones (waveform)
2018-07-13 15:00:21 Dave Jones landscape: status Triaged In Progress
2018-07-25 15:00:59 Dave Jones information type Proprietary Public
2018-07-25 15:01:23 Dave Jones affects landscape landscape-client
2018-07-31 15:32:36 Dave Jones landscape-client: status In Progress Fix Committed
2018-11-01 13:19:49 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/358162
2018-11-01 13:21:14 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/358163
2018-11-01 14:02:26 Simon Poirier description Steps to reproduce: 1) Add tag to a landscape-client, ex assgn tag 'täg 2) Go to scripts in the GUI page and attempt to execute script on that client 3) Script will attempt to run on client and will fail, GUI will show below error: [Failure instance: Traceback: <type 'exceptions.TypeError'>: Environment contains a non-string value /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:176:_handle_execute_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:292:run_script /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:306:addCallback /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:295:addCallbacks --- <exception caught here> --- /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:577:_runCallbacks /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:290:prepare_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:129:_run_script /usr/lib/python2.7/dist-packages/twisted/internet/posixbase.py:336:spawnProcess /usr/lib/python2.7/dist-packages/twisted/internet/base.py:923:_checkProcessArgs ] Above exception is generated by the client w/ LANDSCAPE_COMPUTER_TAGS value being None [Impact] * Script execution fails on computers with non-ascii tags * This is a fairly simple bugfix which is easy to trigger [Test Case] * Tagging a client with accented characters and running a simple "echo script" should be enough to validate the encoding correction. [Regression Potential] * The tag encoding change for scripts is trivial for recent clients. It affects only code related to running shell script and, assuming bad system encoding, should still work the same for ASCII tags. * However, the nature of python2.7 handling of encoding for trusty and xenial is different enough for this patch not to be included for them, thus avoiding regressions on those clients. [Original Description] Steps to reproduce: 1) Add tag to a landscape-client, ex assgn tag 'täg 2) Go to scripts in the GUI page and attempt to execute script on that client 3) Script will attempt to run on client and will fail, GUI will show below error: [Failure instance: Traceback: <type 'exceptions.TypeError'>: Environment contains a non-string value /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:176:_handle_execute_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:292:run_script /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:306:addCallback /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:295:addCallbacks --- <exception caught here> --- /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:577:_runCallbacks /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:290:prepare_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:129:_run_script /usr/lib/python2.7/dist-packages/twisted/internet/posixbase.py:336:spawnProcess /usr/lib/python2.7/dist-packages/twisted/internet/base.py:923:_checkProcessArgs ] Above exception is generated by the client w/ LANDSCAPE_COMPUTER_TAGS value being None
2018-11-14 19:42:49 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/358799
2018-11-20 18:54:54 Alex Moldovan tags low-hanging-fruit lds-squad low-hanging-fruit
2018-11-29 14:16:25 David Coronel bug added subscriber David Coronel
2018-11-29 19:45:46 Andreas Hasenack landscape-client: assignee Dave Jones (waveform) Simon Poirier (simpoir)
2018-11-29 19:46:03 Andreas Hasenack bug task added landscape-client (Ubuntu)
2018-11-29 19:46:18 Andreas Hasenack nominated for series Ubuntu Cosmic
2018-11-29 19:46:18 Andreas Hasenack bug task added landscape-client (Ubuntu Cosmic)
2018-11-29 19:46:38 Andreas Hasenack landscape-client (Ubuntu): status New Fix Released
2018-11-29 19:46:43 Andreas Hasenack landscape-client (Ubuntu Cosmic): status New In Progress
2018-11-29 19:46:50 Andreas Hasenack landscape-client (Ubuntu Cosmic): assignee Simon Poirier (simpoir)
2018-11-29 19:47:01 Andreas Hasenack landscape-client (Ubuntu): assignee Simon Poirier (simpoir)
2018-11-29 19:50:14 Andreas Hasenack nominated for series Ubuntu Bionic
2018-11-29 19:50:14 Andreas Hasenack bug task added landscape-client (Ubuntu Bionic)
2018-11-29 19:50:21 Andreas Hasenack landscape-client (Ubuntu Bionic): status New In Progress
2018-11-29 19:50:27 Andreas Hasenack landscape-client (Ubuntu Bionic): assignee Simon Poirier (simpoir)
2018-11-29 19:50:31 Andreas Hasenack landscape-client (Ubuntu): importance Undecided Low
2018-11-29 19:50:33 Andreas Hasenack landscape-client (Ubuntu Bionic): importance Undecided Low
2018-11-29 19:50:35 Andreas Hasenack landscape-client (Ubuntu Cosmic): importance Undecided Low
2018-12-14 11:49:27 Timo Aaltonen landscape-client (Ubuntu Cosmic): status In Progress Fix Committed
2018-12-14 11:49:29 Timo Aaltonen bug added subscriber Ubuntu Stable Release Updates Team
2018-12-14 11:49:31 Timo Aaltonen bug added subscriber SRU Verification
2018-12-14 11:49:35 Timo Aaltonen tags lds-squad low-hanging-fruit lds-squad low-hanging-fruit verification-needed verification-needed-cosmic
2018-12-14 11:52:19 Timo Aaltonen landscape-client (Ubuntu Bionic): status In Progress Fix Committed
2018-12-14 11:52:24 Timo Aaltonen tags lds-squad low-hanging-fruit verification-needed verification-needed-cosmic lds-squad low-hanging-fruit verification-needed verification-needed-bionic verification-needed-cosmic
2019-02-05 01:52:10 Simon Poirier description [Impact] * Script execution fails on computers with non-ascii tags * This is a fairly simple bugfix which is easy to trigger [Test Case] * Tagging a client with accented characters and running a simple "echo script" should be enough to validate the encoding correction. [Regression Potential] * The tag encoding change for scripts is trivial for recent clients. It affects only code related to running shell script and, assuming bad system encoding, should still work the same for ASCII tags. * However, the nature of python2.7 handling of encoding for trusty and xenial is different enough for this patch not to be included for them, thus avoiding regressions on those clients. [Original Description] Steps to reproduce: 1) Add tag to a landscape-client, ex assgn tag 'täg 2) Go to scripts in the GUI page and attempt to execute script on that client 3) Script will attempt to run on client and will fail, GUI will show below error: [Failure instance: Traceback: <type 'exceptions.TypeError'>: Environment contains a non-string value /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:176:_handle_execute_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:292:run_script /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:306:addCallback /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:295:addCallbacks --- <exception caught here> --- /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:577:_runCallbacks /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:290:prepare_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:129:_run_script /usr/lib/python2.7/dist-packages/twisted/internet/posixbase.py:336:spawnProcess /usr/lib/python2.7/dist-packages/twisted/internet/base.py:923:_checkProcessArgs ] Above exception is generated by the client w/ LANDSCAPE_COMPUTER_TAGS value being None [Impact]  * Script execution fails on computers with non-ascii tags  * This is a fairly simple bugfix which is easy to trigger [Test Case] * Unset locale (/etc/default/locale)  * Tagging a client with accented characters and running a simple    "echo script" should be enough to validate the encoding correction. [Regression Potential]  * The tag encoding change for scripts is trivial for recent clients.    It affects only code related to running shell script and, assuming bad    system encoding, should still work the same for ASCII tags.  * However, the nature of python2.7 handling of encoding for trusty    and xenial is different enough for this patch not to be included    for them, thus avoiding regressions on those clients. [Original Description] Steps to reproduce: 1) Add tag to a landscape-client, ex assgn tag 'täg 2) Go to scripts in the GUI page and attempt to execute script on that client 3) Script will attempt to run on client and will fail, GUI will show below error: [Failure instance: Traceback: <type 'exceptions.TypeError'>: Environment contains a non-string value /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:176:_handle_execute_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:292:run_script /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:306:addCallback /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:295:addCallbacks --- <exception caught here> --- /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:577:_runCallbacks /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:290:prepare_script /usr/lib/python2.7/dist-packages/landscape/manager/scriptexecution.py:129:_run_script /usr/lib/python2.7/dist-packages/twisted/internet/posixbase.py:336:spawnProcess /usr/lib/python2.7/dist-packages/twisted/internet/base.py:923:_checkProcessArgs ] Above exception is generated by the client w/ LANDSCAPE_COMPUTER_TAGS value being None
2019-02-05 01:52:49 Simon Poirier tags lds-squad low-hanging-fruit verification-needed verification-needed-bionic verification-needed-cosmic lds-squad low-hanging-fruit verification-done-bionic verification-done-cosmic
2019-02-07 19:36:27 Launchpad Janitor landscape-client (Ubuntu Cosmic): status Fix Committed Fix Released
2019-02-07 19:37:05 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2019-02-07 19:38:16 Launchpad Janitor landscape-client (Ubuntu Bionic): status Fix Committed Fix Released