Activity log for bug #1728681

Date Who What changed Old value New value Message
2017-10-30 18:25:47 Kellen Renshaw bug added bug
2017-10-30 18:30:17 Kellen Renshaw tags sts
2017-10-30 18:51:41 Andreas Hasenack bug task added landscape-client
2017-12-11 21:20:04 Cameron Childress bug added subscriber Cameron Childress
2019-05-20 20:12:15 Launchpad Janitor landscape-client (Ubuntu): status New Confirmed
2019-05-21 08:18:38 Adam Collard landscape-client (Ubuntu): importance Undecided Low
2019-05-21 08:18:46 Adam Collard landscape-client: status New Triaged
2019-05-21 08:18:49 Adam Collard landscape-client: importance Undecided Critical
2019-05-21 08:18:53 Adam Collard landscape-client: importance Critical Low
2019-05-21 08:28:59 Teluka bug added subscriber Mateusz Pawlowski
2019-05-21 21:26:09 Simon Poirier landscape-client: status Triaged Confirmed
2019-05-24 14:40:29 Simon Poirier landscape-client: assignee Simon Poirier (simpoir)
2019-05-24 21:37:21 Simon Poirier landscape-client: status Confirmed In Progress
2019-06-17 23:03:12 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/368945
2019-06-18 22:42:33 Simon Poirier description Tested on 14.04.5, landscape-client (14.12-0ubuntu6.14.04). If the data_path directive is not present in /etc/landscape/client.conf, the postinst script will fail with the following error: Setting up landscape-client (14.12-0ubuntu6.14.04) ... install: missing file operand Try 'install --help' for more information. dpkg: error processing package landscape-client (--configure): subprocess installed post-installation script returned error exit status 1 Errors were encountered while processing: landscape-client E: Sub-process /usr/bin/dpkg returned an error code (1) Relevant section of the postinst script: # In response to bug 1508110 we need to trigger a complete update of # user information. The flag file will be removed by the client when # the update completes. DATA_PATH="`grep ^data_path /etc/landscape/client.conf | cut -d= -f2 | tr -d '[[:space:]]'`" install --owner=landscape --directory $DATA_PATH USER_UPDATE_FLAG_FILE="$DATA_PATH/user-update-flag" install --owner=landscape /dev/null $USER_UPDATE_FLAG_FILE It would be helpful if the script checked for data_path's existence and emitted a more informative error message. How to reproduce: Install/configure/register landscape-client. Remove landscape-client Remove data_path from /etc/landscape/client.conf Reinstall landscape-client. [Impact] * Manually editing landscape client.conf to unset the data_path blocks upgrade postinst. That field was not required to be present before 14.04, and older configurations can fail to upgrade without purging the existing configuration. * Although data_path is set by default, removing the line is accepted by landscape and it will use a default path. The fix simply makes sure the postinst script also has that default. [Test Case] * sed -i -e '/data_path/d' /etc/landscape/client.conf * apt install --reinstall landscape-client [Regression Potential] * The change is fairly trivial. Regression could be possible if the default paths were changed and not reflected in the postinst. In such a case the resync flag file wouldn't be created, resulting in an out-of-sync list of users; this would be low impact. [Original Description] Tested on 14.04.5, landscape-client (14.12-0ubuntu6.14.04). If the data_path directive is not present in /etc/landscape/client.conf, the postinst script will fail with the following error: Setting up landscape-client (14.12-0ubuntu6.14.04) ... install: missing file operand Try 'install --help' for more information. dpkg: error processing package landscape-client (--configure):  subprocess installed post-installation script returned error exit status 1 Errors were encountered while processing:  landscape-client E: Sub-process /usr/bin/dpkg returned an error code (1) Relevant section of the postinst script:  # In response to bug 1508110 we need to trigger a complete update of         # user information. The flag file will be removed by the client when         # the update completes.         DATA_PATH="`grep ^data_path /etc/landscape/client.conf | cut -d= -f2 | tr -d '[[:space:]]'`"         install --owner=landscape --directory $DATA_PATH         USER_UPDATE_FLAG_FILE="$DATA_PATH/user-update-flag"         install --owner=landscape /dev/null $USER_UPDATE_FLAG_FILE It would be helpful if the script checked for data_path's existence and emitted a more informative error message. How to reproduce: Install/configure/register landscape-client. Remove landscape-client Remove data_path from /etc/landscape/client.conf Reinstall landscape-client.
2019-06-20 12:06:49 Michael Spurlock bug added subscriber Michael Spurlock
2019-06-21 20:32:38 Launchpad Janitor landscape-client (Ubuntu): status Confirmed Fix Released
2019-06-28 13:28:09 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/369449
2019-06-28 17:33:40 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/369457
2019-06-28 17:34:09 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/369458
2019-07-09 16:42:36 Brian Murray landscape-client (Ubuntu Disco): status New Fix Committed
2019-07-09 16:42:38 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2019-07-09 16:42:41 Brian Murray bug added subscriber SRU Verification
2019-07-09 16:42:48 Brian Murray tags sts sts verification-needed verification-needed-disco
2019-07-12 20:29:57 Launchpad Janitor merge proposal linked https://code.launchpad.net/~simpoir/ubuntu/+source/landscape-client/+git/landscape-client/+merge/370075
2019-07-19 18:52:45 Brian Murray landscape-client (Ubuntu Bionic): status New Fix Committed
2019-07-19 18:52:52 Brian Murray tags sts verification-needed verification-needed-disco sts verification-needed verification-needed-bionic verification-needed-disco
2019-07-25 22:08:18 Simon Poirier tags sts verification-needed verification-needed-bionic verification-needed-disco sts verification-done-bionic verification-done-disco verification-needed
2019-08-13 20:24:10 Brian Murray landscape-client (Ubuntu Xenial): status New Fix Committed
2019-08-13 20:24:18 Brian Murray tags sts verification-done-bionic verification-done-disco verification-needed sts verification-done-bionic verification-done-disco verification-needed verification-needed-xenial
2019-08-27 00:44:15 Chris Johnston tags sts verification-done-bionic verification-done-disco verification-needed verification-needed-xenial sts verification-done-bionic verification-done-disco verification-done-xenial verification-needed
2019-09-09 09:25:23 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2019-09-09 09:28:04 Launchpad Janitor landscape-client (Ubuntu Bionic): status Fix Committed Fix Released
2019-09-09 09:35:28 Launchpad Janitor landscape-client (Ubuntu Disco): status Fix Committed Fix Released
2019-09-25 21:23:02 Robie Basak landscape-client (Ubuntu Xenial): status Fix Committed Incomplete
2019-11-12 21:53:04 Simon Poirier landscape-client (Ubuntu Xenial): status Incomplete Fix Committed
2019-11-12 21:53:20 Simon Poirier tags sts verification-done-bionic verification-done-disco verification-done-xenial verification-needed sts verification-done verification-done-bionic verification-done-disco verification-done-xenial
2019-11-13 00:08:20 Launchpad Janitor landscape-client (Ubuntu Xenial): status Fix Committed Fix Released