Client backtraces and hangs when incorrect account/pass is given

Bug #1429888 reported by Andreas Hasenack on 2015-03-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
High
Chris Glass
landscape-client (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Unassigned

Bug Description

Trunk client r812. Try to register with an incorrect account/password combination and it will backtrace like this, and hang indefinitely.

 * Stopping landscape-client daemon [fail]
 * Starting the landscape-client daemon [ OK ]
Please wait...

Request a new registration for this computer now? (Y/n):
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/dist-packages/landscape/lib/amp.py", line 402, in _handle_failure
    deferred.errback(failure)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 423, in errback
    self._startRunCallbacks(fail)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/dist-packages/landscape/configuration.py", line 607, in handle_registration_errors
    failure.trap(InvalidCredentialsError, MethodCallError)
exceptions.AttributeError: 'RemoteBrokerConnector' object has no attribute 'trap'

Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/dist-packages/landscape/lib/amp.py", line 402, in _handle_failure
    deferred.errback(failure)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 423, in errback
    self._startRunCallbacks(fail)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/dist-packages/landscape/configuration.py", line 607, in handle_registration_errors
    failure.trap(InvalidCredentialsError, MethodCallError)
exceptions.AttributeError: 'RemoteBrokerConnector' object has no attribute 'trap'

(hangs indefinetely)

Found by robot, test run was taking days and had to be aborted.

Related branches

Andreas Hasenack (ahasenack) wrote :

With landscape-client14.12 this doesn't happen.

Andreas Hasenack (ahasenack) wrote :

r811 is fine too.

tags: removed: kanban
Chris Glass (tribaal) on 2015-03-11
Changed in landscape-client:
assignee: nobody → Chris Glass (tribaal)
status: New → In Progress
Andreas Hasenack (ahasenack) wrote :

Once this lands, please remove the skip tag from the robot test in landscape/trunk (server):

=== modified file 'robot/system/test/client/upgrade.txt'
--- robot/system/test/client/upgrade.txt 2015-03-10 18:45:51 +0000
+++ robot/system/test/client/upgrade.txt 2015-03-12 16:07:01 +0000
@@ -5,8 +5,7 @@
 Suite Setup Client Upgrade Suite Setup
 Suite Teardown Client Upgrade Suite Teardown
 Test Setup Default Setup
-# XXX remove skip tag after #1429888 is fixed
-Force Tags client-upgrade skip
+Force Tags client-upgrade

 *** Variables ***

Changed in landscape-client:
status: In Progress → Fix Committed
Changed in landscape-client:
milestone: none → 15.04
Changed in landscape-client:
status: Fix Committed → Fix Released
Changed in landscape-client:
status: Fix Released → Fix Committed
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers