Landscape Client

Send minimal Juju information on registration

Bug #1229630 reported by Chris Glass
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
High
Adam Collard
Landscape Client 13.09.1

Bug Description

We need to send a minimal set of information about juju environments the computer belongs to at registration, to detect juju environments not registered with landscape, or to auto-accept computers that are part of an already-known environment.

Tags: squad-gamma

Related branches

lp:~adam-collard/landscape-client/juju-info-at-registration
Björn Tillenius (community): Approve
Alberto Donato (community): Approve
Diff: 614 lines (+240/-118)
13 files modified
landscape/broker/registration.py (+69/-51)
landscape/broker/tests/helpers.py (+3/-0)
landscape/broker/tests/test_registration.py (+38/-7)
landscape/deployment.py (+5/-0)
landscape/lib/juju.py (+26/-0)
landscape/lib/tests/test_encoding.py (+1/-1)
landscape/lib/tests/test_juju.py (+62/-0)
landscape/message_schemas.py (+10/-4)
landscape/monitor/config.py (+0/-7)
landscape/monitor/jujuinfo.py (+4/-22)
landscape/monitor/tests/test_config.py (+0/-11)
landscape/monitor/tests/test_jujuinfo.py (+9/-12)
landscape/tests/test_deployment.py (+13/-3)
LKK Automation (lp2kanban)
tags: removed: kanban
Revision history for this message
Chris Glass (tribaal) wrote :

The minimal information would be:

free:
- Environment UUID
- API endpoint

ack : possibly the unit name as well, to handle the case of removing a unit that is associated to the computer

Björn Tillenius (bjornt)
Changed in landscape-client:
assignee: nobody → Björn Tillenius (bjornt)
status: New → In Progress
milestone: none → 13.09.1
Revision history for this message
Chris Glass (tribaal) wrote :

More info from IRC:

<ack> free, when we create the computer in landscape, we need to associate it with the unit
<free> ack: why?
<ack> free, if we do it later (as we do now) the unit might have been gone in the meantime but we don't know that that computer was linked that unit, so we don't remove it
 free, which is essentially #1224877
<_mup_> Bug #1224877: Unit destruction not always results in the removal of the associated landscape computer <defect> <Landscape Server:New> <https://launchpad.net/bugs/1224877>

Adam Collard (adam-collard)
Changed in landscape-client:
assignee: Björn Tillenius (bjornt) → Adam Collard (adam-collard)
🤖 Landscape Builder (landscape-builder)
Changed in landscape-client:
status: In Progress → Fix Committed
Andreas Hasenack (ahasenack)
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.