Client removes config values from config files if they match defaults.
Bug #1221633 reported by
Geoff Teale
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Client |
Fix Released
|
Low
|
Geoff Teale |
Bug Description
This bug splits out one aspect of bug #1216696 that can be easily fixed: currently whenever the landscape client modifies its config file it writes a new file, and omits any config values that match the defaults and weren't explicitly passed on the command line. To fix this issue we simply need to respect values that already existed in the config file in the same way we respect options passed on the command line (whilst still giving the command line precedence). That intended functionality will therefore be that we don't write *additional* default values to the file.
Related branches
lp:~tealeg/landscape-client/prevent-overwriting-config
- Chris Glass (community): Approve
- Alberto Donato (community): Approve
-
Diff: 75 lines (+22/-1)3 files modifiedlandscape/deployment.py (+2/-1)
landscape/tests/test_configuration.py (+3/-0)
landscape/tests/test_deployment.py (+17/-0)
tags: | removed: kanban |
Changed in landscape-client: | |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in landscape-client: | |
status: | In Progress → Fix Committed |
Changed in landscape-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.