Incorrect/Misleading key name in landscape-client charm and landscape-config tool, "ssl public key"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Client |
Triaged
|
Undecided
|
Unassigned | ||
landscape-client-charm |
Triaged
|
Undecided
|
Unassigned | ||
landscape-client (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
The issue is in the landscape-client charm's config, with the key name "ssl-public-key", as well as in the landscape-config tool (which is part of the landscape-client), with the cli option -k SS:_PUBLIC KEY, --ssl-public-
Below is the entry in the landscape-client charmhub page:
```
ssl-public-key | string
The CA certificate to verify the server certificate with. This can be
a path to a file, or a base64 encoded entry of the certificate itself,
prefixed with "base64:". This config is only used if the message server
URL given above starts with https.
```
And in the man page of landscape-config:
```
-k SSL_PUBLIC_KEY, --ssl-public-
The SSL CA certificate to verify the server with. Only used if the server URL to which we connect is https.
```
Additionally, when using the `landscape-config` tool, it will ask the user to supply the --ssl-public-key option, so the change needs to be done on all occurrences.
The word "key" should be changed to something more accurate, such as "cert".
summary: |
- Incorrect/Misleading key name in landscape-client "ssl-public-key" + Incorrect/Misleading key name in landscape-client charm config "ssl- + public-key" |
summary: |
- Incorrect/Misleading key name in landscape-client charm config "ssl- - public-key" + Incorrect/Misleading key name in landscape-client charm and landscape- + config tool, "ssl public key" |
description: | updated |
Changed in landscape-client: | |
status: | New → Confirmed |
Changed in landscape-client-charm: | |
status: | New → Confirmed |
Changed in landscape-client (Ubuntu): | |
status: | New → Confirmed |
Changed in landscape-client: | |
status: | Confirmed → Triaged |
Changed in landscape-client-charm: | |
status: | Confirmed → Triaged |
For the sake of consistency with other charms like for openstack charms I would go with ssl-ca
Also the landscape client should be update to match the correct naming convention
``` client. conf|grep ssl_public_key certs/landscape _server_ ca.crt certs/landscape _server_ ca.crt ....... ....... ..J4Z4wDQYJKoZI hvcNAQEL ....... ....... .....1VEIEVudGV ycHJpc2UgSXNzdW luZyBDQSAx
root@vault-1:~# cat /etc/landscape/
ssl_public_key = /etc/ssl/
root@vault-1:~# head /etc/ssl/
-----BEGIN CERTIFICATE-----
MIIEOTCCAyGg.
BQAwLDEq.
```