landscape-client-charm

harmonize apt sources and keys configuration

Bug #1813447 reported by Dmitrii Shcherbakov
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Landscape Charm
Fix Released
Medium
Adam Collard
landscape-client-charm
Fix Committed
Medium
Adam Collard

Bug Description

Currently landscape charms provide different mechanisms to configure apt keys and options which is confusing for deployers and operators.

It would be good to standardize on something common such as install_sources and install_keys options implemented in many reactive charms (which depend on layer-apt).

Tags: cpe-onsite

Related branches

lp:~adam-collard/landscape-charm/install-sources-keys
Simon Poirier (community): Approve
🤖 Landscape Builder: Approve (test results)
Diff: 278 lines (+93/-17)
11 files modified
Makefile (+1/-1)
config.yaml (+24/-1)
dev/ubuntu-deps (+2/-1)
lib/apt.py (+18/-1)
lib/callbacks/tests/test_apt.py (+1/-1)
lib/tests/stubs.py (+8/-1)
lib/tests/test_apt.py (+34/-6)
lib/tests/test_install.py (+1/-1)
lib/tests/test_services.py (+1/-1)
lib/tests/test_upgrade.py (+1/-1)
tests/helpers.py (+2/-2)
lp:~adam-collard/landscape-client-charm/install_sources_keys
Simon Poirier (community): Approve
🤖 Landscape Builder: Approve (test results)
Diff: 391 lines (+86/-70)
10 files modified
Makefile (+9/-1)
TESTING (+3/-1)
config.yaml (+21/-0)
dev/ubuntu-deps (+1/-5)
hooks/common.py (+4/-1)
hooks/hooks.py (+7/-5)
hooks/install.py (+14/-49)
hooks/stubs.py (+6/-0)
hooks/test_hooks.py (+20/-7)
tests/10-deploy-register.py (+1/-1)
lp:~npochet/landscape-charm/landscape-charm
🤖 Landscape Builder: Needs Fixing (test results)
Simon Poirier (community): Needs Information
Diff: 12 lines (+1/-1)
1 file modified
lib/apt.py (+1/-1)
Revision history for this message
Dmitrii Shcherbakov (dmitriis) wrote :

install_sources and install_keys have been implemented for landscape (server) charm and are available as of revision 30 in the charm store.

Changed in landscape-charm:
status: New → Fix Released
Adam Collard (adam-collard)
Changed in landscape-charm:
assignee: nobody → Adam Collard (adam-collard)
importance: Undecided → Medium
Adam Collard (adam-collard)
Changed in landscape-client-charm:
status: New → In Progress
assignee: nobody → Adam Collard (adam-collard)
importance: Undecided → Medium
Revision history for this message
Dmitrii Shcherbakov (dmitriis) wrote :

Seems like the install_sources code path does not execute apt update somehow:

unit-landscape-xenial-full-keyid-0: 01:07:52 DEBUG unit.landscape-xenial-full-keyid/0.install subprocess.CalledProcessError: Command '['apt-get', '--assume-yes', '--option=Dpkg::Options::=--force-confold', 'install', 'landscape-server', 'landscape-hashids', 'python-minimal', 'python-psutil']' returned non-zero exit status 100
unit-landscape-xenial-full-keyid-0: 01:07:52 ERROR juju.worker.uniter.operation hook "install" failed: exit status 1

https://paste.ubuntu.com/p/kGy9FspD8G/

  install_sources: |
    - 'deb http://ppa.launchpad.net/landscape/19.01/ubuntu xenial main'
  install_keys: |
    - 35F77D63B5CEC106C577ED856E85A86E4652B4E6

Changed in landscape-charm:
status: Fix Released → New
🤖 Landscape Builder (landscape-builder)
Changed in landscape-client-charm:
status: In Progress → Fix Committed
Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

It looks like install_keys is being handled after install_sources:

http://paste.ubuntu.com/p/pD57DDvWCM/

Jason Hobbs (jason-hobbs)
Changed in landscape-charm:
status: New → In Progress
Jason Hobbs (jason-hobbs)
Changed in landscape-charm:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.