landscape-server doesn't export check definitions

[Barry Price]

The landscape-server charm appears to have its own implementation to set up and write nagios check configuration to disk.

The way things are currently handled, while the service checks are indeed written correctly to /etc/nagios/nrpe.d, they're not then exported to /var/lib/nagios/export even when export_nagios_definitions is set to True on the nrpe subordinate.

The end result is that when we instruct the nagios server to import all defined checks, Landscape's own checks aren't picked up, and we miss monitoring rules.

I'd suggest maybe using the nrpe library to set up the checks instead, which should include export awareness for free:

https://github.com/canonical/ops-lib-nrpe

[Barry Price (barryprice)]

n.b. We've worked around this for now by manually running this Python script on each landscape-server unit:

https://paste.ubuntu.com/p/6FcZHgDjjM/