Install cluster with provider KVM but without virsh installed provided wrong message

[Loic Lescouzeres]

How to reproduce :
1 - Be sure not to have virsh installed
2 - git clone git://git.openstack.org/openstack/training-labs.git
3 - cd training-labs/labs
4 - sed -i.bak 's/${PROVIDER:=virtualbox}/${PROVIDER:=kvm}/' config/localrc
5 - ./st.py -b cluster

I then get the following message :
'No handlers could be found for logger "stacktrain.config.general"'

After diving into the script I realized that I was missing virsh command tools.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/661441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/661441
Committed: https://git.openstack.org/cgit/openstack/training-labs/commit/?id=af042e0716413f372160c7718fb99e8bf28cc864
Submitter: Zuul
Branch: master

commit af042e0716413f372160c7718fb99e8bf28cc864
Author: Roger Luethi <email address hidden>
Date: Sat May 25 12:17:05 2019 +0200

    Don't use logger before it is configured

    This patch removes the first call to check_provider. Because logging
    is not configured when the file is imported, any calls to logger.error
    result only this unhelpful error message being shown:

      No handlers could be found for logger "stacktrain.config.general"

    The check_provider call in st.py is the only one we need.

    backport: rocky queens

    Closes-Bug: #1803341

    Change-Id: Ie75ca928b13a51433f8d61500407049a0e636d45