debugger can't be used with unit tests

Bug #1626542 reported by Antoni Segura Puimedon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kuryr-libnetwork
Fix Released
High
Antoni Segura Puimedon

Bug Description

Our base test class is taken from python-neutronclient, which captures the stdin and stdout preventing us from attaching the debugger when running unit tests. This is very inconvenient when adding new tests and refactoring, because not only you cannot attach the debugger, but you can't either do prints.

Changed in kuryr-libnetwork:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Antoni Segura Puimedon (celebdor)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-libnetwork (master)

Fix proposed to branch: master
Review: https://review.openstack.org/374793

Changed in kuryr-libnetwork:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-libnetwork (master)

Reviewed: https://review.openstack.org/374793
Committed: https://git.openstack.org/cgit/openstack/kuryr-libnetwork/commit/?id=5214e66f9165a1b4a819a860eb8f31c9a81b343f
Submitter: Jenkins
Branch: master

commit 5214e66f9165a1b4a819a860eb8f31c9a81b343f
Author: Antoni Segura Puimedon <email address hidden>
Date: Thu Sep 22 14:56:35 2016 +0200

    unit_tests: do not base our tests on neutronclient

    The python-neutronclient module that we were getting our base test class
    from was intended to serve for tests that emulate command line input and
    output and, as such, it took control of stdin and stdout.

    It is inconvenient to have stdin and stdout captured because that
    prevents the developers from printing or attaching debuggers when
    running unit tests.

    Change-Id: I729652d0b5bf8a852950535cce36195397165581
    Closes-bug: #1626542
    Signed-off-by: Antoni Segura Puimedon <email address hidden>

Changed in kuryr-libnetwork:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.