[OVN] OVN compilation is failing in "neutron-tempest-plugin-scenario-ovn" job

[Rodolfo Alonso]

Log example: https://82fb88856366a93f38a2-868b7eb6ba44b32e3b412bc5acf60e73.ssl.cf2.rackcdn.com/792998/9/check/neutron-tempest-plugin-scenario-ovn/fd8fdbd/job-output.txt

Snippet: https://paste.opendev.org/show/beKFYCj63gTn96HLdkcE/

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

It seems that [1] is changing the method signature of "inet_parse_active" and this is breaking OVN compilation.

[1]https://github.com/openvswitch/ovs/commit/0a3867a9a9fb2e1680272e6318cf25c5ae220102

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Ok, I've talked to Dumitru Ceara, mantainer of OVS and OVN. For OVN "branch-21.06" tag, the needed OVS commits are (from [1]):
"""
Bump the OVS submodule to include the following patches:
  dd0f59783e39 ("ofproto: Fix potential NULL dereference in ofproto_get_datapath_cap().")
  a4b04276ab59 ("ofproto: Fix potential NULL dereference in ofproto_ct_*_zone_timeout_policy().")
"""

I'll push a patch pinning OVS to a4b04276ab5934d087669ff2d191a23931335c87.

[1]https://github.com/ovn-org/ovn/commit/4b0a02635fde3d356851dddf12936d9ff2fcc874

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/836121

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/836122

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/836122
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/93f1e9b3e738745f660a17c185012784f9be69d4
Submitter: "Zuul (22348)"
Branch: master

commit 93f1e9b3e738745f660a17c185012784f9be69d4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sun Mar 20 06:47:39 2022 +0000

    [OVN] Pin OVS version for OVN v21.06.0

    According to [1], the needed version for OVN v21.06.0 is
    a4b04276ab5934d087669ff2d191a23931335c87

    [1]https://github.com/ovn-org/ovn/commit/4b0a02635fde3d356851dddf12936d9ff2fcc874

    Closes-Bug: #1967472
    Change-Id: I103f3a63b1d95f79b9e72f1bad197a39a4713da3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/836121
Committed: https://opendev.org/openstack/neutron/commit/4e98078e7ac7de8261b4e6216e51a135d458b4ac
Submitter: "Zuul (22348)"
Branch: master

commit 4e98078e7ac7de8261b4e6216e51a135d458b4ac
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sun Mar 20 06:44:16 2022 +0000

    [OVN] Pin OVS version for OVN v21.06.0

    According to [1], the needed version for OVN v21.06.0 is
    a4b04276ab5934d087669ff2d191a23931335c87

    [1]https://github.com/ovn-org/ovn/commit/4b0a02635fde3d356851dddf12936d9ff2fcc874

    Closes-Bug: #1967472
    Change-Id: I1ecb31281ded60b396d408aa5c303081a90c4ae2

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/836144
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/faead99aa3507577fe32b87a6b405838e83290f1
Submitter: "Zuul (22348)"
Branch: master

commit faead99aa3507577fe32b87a6b405838e83290f1
Author: Fernando Royo <email address hidden>
Date: Fri Apr 1 13:29:43 2022 +0200

    [OVN] Pin OVS version for OVN v21.06.0

    According to [1], the needed version for OVN v21.06.0 is
    a4b04276ab5934d087669ff2d191a23931335c87

    [1]https://github.com/ovn-org/ovn/commit/4b0a02635fde3d356851dddf12936d9ff2fcc874

    And according to [2], the need version of job using OVN
    master is 498cedc483f3239c839c55b4d9f2261b61fb6ace

    [2] https://github.com/ovn-org/ovn/commit/576491f50721748ddfb2541ad1ef793ed9cba69d

    Related-Bug: #1967472
    Change-Id: I63cfc82b329687204e08c2061c6ac8eb7582ab77

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/839083

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/839083
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/201e8be0469be0e27d40e720c351cb2a2c095170
Submitter: "Zuul (22348)"
Branch: master

commit 201e8be0469be0e27d40e720c351cb2a2c095170
Author: Fernando Royo <email address hidden>
Date: Fri Apr 22 18:27:22 2022 +0200

    [OVN] Fix DuplicateOptionError on test scope

    OVN Octavia Provider is registering opts a soon modules (driver,
    agent or helper) are imported, so in a test scope terms, when some
    tests run the setUp they are broken by a DuplicateOptionError
    because they are based on TestOVNFunctionalBase from Neutron
    where same options are loaded to same oslo_config group.

    This fix proposes some refactoring in a similar way to [1] and [2]
    in order to avoid the registration of opts a soon a module is
    imported, instead we switch to one charge per required class
    whenever possible.

    Additionally in order to fix gates and according to [3], we pin
    version of OVS to d94cd0d3eec33e4290d7ca81918f5ac61444886e hash

    [1] https://review.opendev.org/c/openstack/neutron/+/837392
    [2] https://review.opendev.org/c/openstack/neutron/+/839783
    [3] https://github.com/ovn-org/ovn/commit/f93206ce40ae38f26ffaf69c5d79a63abfbd5e3c

    Related-Bug: #1972278
    Related-Bug: #1967472

    Change-Id: I2f36af767a0a0a4c19488b6998a414b8672114f5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-tempest-plugin 2.0.0 release.