kuryr-kubernetes

Clean up unused method _generate_lbaas_port_specs

Bug #1901161 reported by Maysa de Macedo Souza on 2020-10-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ kuryr-kubernetes
Fix Released
Undecided
Kafilat Adeleke
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

The _generate_lbaas_port_specs method[1] on the lbaas handler is not used anymore, so it should be removed along with the unit tests for it.

[1] https://github.com/openstack/kuryr-kubernetes/blob/stable/victoria/kuryr_kubernetes/controller/handlers/lbaas.py#L234-L236

See original description
Maysa de Macedo Souza (maysa) on 2020-10-23
description: updated
Kafilat Adeleke (kafilat-adeleke) on 2020-10-23
Changed in kuryr-kubernetes:
assignee: nobody → Kafilat Adeleke (kafilat-adeleke)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-kubernetes (master)

Fix proposed to branch: master
Review: https://review.opendev.org/759390

Changed in kuryr-kubernetes:
status: New → In Progress
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-kubernetes (master)

Reviewed: https://review.opendev.org/759390
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=ba1275337463a9d21688597329a797ac18b4c74d
Submitter: Zuul
Branch: master

commit ba1275337463a9d21688597329a797ac18b4c74d
Author: Kafilat Adeleke <email address hidden>
Date: Fri Oct 23 02:48:26 2020 -0700

    Removes generate_lbaas_port_specs method

    The _generate_lbaas_port_specs method on the lbaas handler
    is not used anymore, it should be removed along with
    the unit tests for it.

    Change-Id: I3982fc6c292a2823c4581897569e885a27b9e406
    Closes-Bug: #1901161

Changed in kuryr-kubernetes:
status: In Progress → Fix Released
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kuryr-kubernetes 4.0.0.0rc1

This issue was fixed in the openstack/kuryr-kubernetes 4.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers