CNI is not returning errors in a specified form

[Michal Dulko]

CNI spec defines the way to return errors from the CNI plugin [1], along with well-defined error codes [2] that can be used by the CNI to decide how to treat the error.

We do not use that, yet we should. The "11 - Try again later." code is probably the most interesting as we could tell the CNI to retry the operation e.g. in case of NetlinkError or when connection to the kuryr-daemon isn't working (because e.g. it's restarting).

[1] https://github.com/containernetworking/cni/blob/spec-v0.4.0/SPEC.md#result
[2] https://github.com/containernetworking/cni/blob/spec-v0.4.0/SPEC.md#well-known-error-codes

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/760255

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/760255
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=3a4d901fa67533c3e1bcdb4f6dc07736ac28167b
Submitter: Zuul
Branch: master

commit 3a4d901fa67533c3e1bcdb4f6dc07736ac28167b
Author: Tabitha <email address hidden>
Date: Wed Oct 28 23:22:11 2020 +0100

    Returns CNI errors in specified form

    CNI spec defines the way to return errors from the CNI plugin, along
    with well-defined error codes that can be used by the CNI to decide
    how to treat the error. This change updates service.py and main.go
    to return CNI errors in the specified form.

    Change-Id: Ib76debb56aeb746b92c8260be00f3445cca5948f
    Closes-Bug: #1899489

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 4.0.0.0rc1 release candidate.