Activity log for bug #1899374

Date Who What changed Old value New value Message
2020-10-11 19:25:04 Maysa de Macedo Souza bug added bug
2020-10-11 19:25:11 Maysa de Macedo Souza kuryr-kubernetes: importance Undecided Medium
2020-10-12 13:57:43 Maysa de Macedo Souza tags low-hanging-fruit
2020-10-14 09:10:07 Maysa de Macedo Souza summary Low test covarage for Service and Endpoints handler [TESTS] Low test covarage for Service and Endpoints handler
2020-10-21 16:38:47 Agha Saad Fraz kuryr-kubernetes: assignee Agha Saad Fraz (aghasaad04)
2020-10-21 19:01:48 Maysa de Macedo Souza summary [TESTS] Low test covarage for Service and Endpoints handler [TESTS] Low test covarage for Endpoints handler
2020-10-21 19:48:54 Maysa de Macedo Souza description The testing coverage for the ServiceHandler and EndpointsHandler[1] is below the ideal. New unit tests[2] need to be created to cover possible scenarios. [1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py [2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py The testing coverage for the EndpointsHandler[1] is below the ideal. New unit tests[2] need to be created to cover possible scenarios. The following scenarios could be added: - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoint has no Pods defined or it's a headless Service. - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoints has annotations defined, as the Endpoints annotations are going to be converted to CRD. [1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py [2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py
2020-10-22 09:24:04 Maysa de Macedo Souza description The testing coverage for the EndpointsHandler[1] is below the ideal. New unit tests[2] need to be created to cover possible scenarios. The following scenarios could be added: - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoint has no Pods defined or it's a headless Service. - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoints has annotations defined, as the Endpoints annotations are going to be converted to CRD. [1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py [2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py The testing coverage for the EndpointsHandler[1] is below the ideal. New unit tests[2] need to be created to cover possible scenarios. The following scenarios could be added: - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoint has no Pods defined or it's a headless Service. - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoints has annotations defined, as the Endpoints annotations are going to be converted to CRD. [1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py [2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py Example of Endpoints with annotation http://paste.openstack.org/show/799270/
2020-10-27 15:26:01 Maysa de Macedo Souza description The testing coverage for the EndpointsHandler[1] is below the ideal. New unit tests[2] need to be created to cover possible scenarios. The following scenarios could be added: - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoint has no Pods defined or it's a headless Service. - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoints has annotations defined, as the Endpoints annotations are going to be converted to CRD. [1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py [2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py Example of Endpoints with annotation http://paste.openstack.org/show/799270/ The testing coverage for the EndpointsHandler[1] is below the ideal. New unit tests[2] need to be created to cover possible scenarios. The following scenarios could be added: - on_present method: check the event is skipped (meaning no crd_spec is created or updated) when the Endpoint has no Pods defined or it's a headless Service. - on_present method: check the event is skipped (meaning no attempt to updated crd) when the Endpoints has annotations defined, as the Endpoints annotations are going to be converted to CRD. [1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py [2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py Example of Endpoints with annotation http://paste.openstack.org/show/799270/