Fail to recreate namespace when previous KuryrNet CRD is not deleted

[Maysa de Macedo Souza]

When a namespace/project is recreated right after its deletion, it's possible that the previous kuryrNet CRD is not yet removed, and Kuryr will try to create another CRD, resulting in k8s conflict exception. In the meantime, other events handling resources under the same namespace in question could be inquiring for an annotation on the namespace, that was not annotated due to the conflict error, resulting in restart of the controller.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/666850

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666850
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=37b8e3e6b37c7ffd3136a1fbefdd7bb0c1739f6e
Submitter: Zuul
Branch: master

commit 37b8e3e6b37c7ffd3136a1fbefdd7bb0c1739f6e
Author: Maysa Macedo <email address hidden>
Date: Fri Jun 21 14:21:29 2019 +0000

    Fix fail to recreate namespace when previous KuryrNet CRD is not deleted

    When a namespace/project is recreated right after its deletion,
    it's possible that the previous kuryrNet CRD is not yet removed,
    and Kuryr will try to create another CRD, resulting in k8s conflict
    exception. In the meantime, other events handling resources under
    the same namespace in question could be inquiring for an annotation
    on the namespace, that was not annotated due to the conflict error,
    causing the controller to restart.

    This commit fixes the issue by adding an annotation to the KuryrNet
    CRD with the respective namespace uid, which allows to check
    if the existing CRD corresponds to the namespace.

    Change-Id: I85d903902b516bfd109078705860540d731886bc
    Closes-Bug: 1833712

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/669800

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669800
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=2a58fa8fb560481b1a070a5c0543c63c1fffbcfe
Submitter: Zuul
Branch: stable/stein

commit 2a58fa8fb560481b1a070a5c0543c63c1fffbcfe
Author: Maysa Macedo <email address hidden>
Date: Fri Jun 21 14:21:29 2019 +0000

    Fix fail to recreate namespace when previous KuryrNet CRD is not deleted

    When a namespace/project is recreated right after its deletion,
    it's possible that the previous kuryrNet CRD is not yet removed,
    and Kuryr will try to create another CRD, resulting in k8s conflict
    exception. In the meantime, other events handling resources under
    the same namespace in question could be inquiring for an annotation
    on the namespace, that was not annotated due to the conflict error,
    causing the controller to restart.

    This commit fixes the issue by adding an annotation to the KuryrNet
    CRD with the respective namespace uid, which allows to check
    if the existing CRD corresponds to the namespace.

    Change-Id: I85d903902b516bfd109078705860540d731886bc
    Closes-Bug: 1833712
    (cherry picked from commit 37b8e3e6b37c7ffd3136a1fbefdd7bb0c1739f6e)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/676681

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676681
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=46b1407deac0e0b44a09fb747ac130f1cd31a2a1
Submitter: Zuul
Branch: stable/rocky

commit 46b1407deac0e0b44a09fb747ac130f1cd31a2a1
Author: Maysa Macedo <email address hidden>
Date: Fri Jun 21 14:21:29 2019 +0000

    Fix fail to recreate namespace when previous KuryrNet CRD is not deleted

    When a namespace/project is recreated right after its deletion,
    it's possible that the previous kuryrNet CRD is not yet removed,
    and Kuryr will try to create another CRD, resulting in k8s conflict
    exception. In the meantime, other events handling resources under
    the same namespace in question could be inquiring for an annotation
    on the namespace, that was not annotated due to the conflict error,
    causing the controller to restart.

    This commit fixes the issue by adding an annotation to the KuryrNet
    CRD with the respective namespace uid, which allows to check
    if the existing CRD corresponds to the namespace.

    Depends-On: https://review.opendev.org/#/c/677487/
    Change-Id: I85d903902b516bfd109078705860540d731886bc
    Closes-Bug: 1833712
    (cherry picked from commit 37b8e3e6b37c7ffd3136a1fbefdd7bb0c1739f6e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 1.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.5.4 release.