kuryr-controller pod restarts continuously due to lb in ERROR status

[Luis Tomas Bolivar]

When a service is created and kuryr starts creating the octavia lb for it, if that lbs goes into ERROR status, kuryr will fail after waiting for it to be ACTIVE. The health checks then will eventually trigger a kuryr-controller restart. However, after the restart, the loadbalancer is already created but in Error status. Thus, the creation of a new one will fail due to lb already exiting, and the kuryr-controller will end up waiting for it to transition to active, which will never happen. This makes kuryr-controller be restarted over and over

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/636890

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636890
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=33594b870297aa88f15d73c221b6aa04709afe6d
Submitter: Zuul
Branch: master

commit 33594b870297aa88f15d73c221b6aa04709afe6d
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Feb 14 10:57:21 2019 +0100

    Ensure kuryr-controller recover from lb in ERROR status

    This patch ensures kuryr controller can recover from the situation
    when the created lb goes into ERROR status (instead of ACTIVE). Now,
    when the kuryr-controller finds the created lb, it checks its
    provisioning_status and if in ERROR status it will delete it and
    ensure a ResourceNotReady exception is triggered so that a new
    creation action is triggered after the deletion of the lb in ERROR
    status.

    Closes-Bug: 1815880
    Change-Id: I3f5de710a5ff37dee05f5f8826cb37c343141a08

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/637724

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/637725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/637724
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=17d26351c96a3e6e7e02191bbff43f4f5de5debe
Submitter: Zuul
Branch: stable/rocky

commit 17d26351c96a3e6e7e02191bbff43f4f5de5debe
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Feb 14 10:57:21 2019 +0100

    Ensure kuryr-controller recover from lb in ERROR status

    This patch ensures kuryr controller can recover from the situation
    when the created lb goes into ERROR status (instead of ACTIVE). Now,
    when the kuryr-controller finds the created lb, it checks its
    provisioning_status and if in ERROR status it will delete it and
    ensure a ResourceNotReady exception is triggered so that a new
    creation action is triggered after the deletion of the lb in ERROR
    status.

    Closes-Bug: 1815880
    Change-Id: I3f5de710a5ff37dee05f5f8826cb37c343141a08
    (cherry picked from commit 33594b870297aa88f15d73c221b6aa04709afe6d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/637725
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=84538d7627aa366ee72735e78fe44ddecd3895f6
Submitter: Zuul
Branch: stable/queens

commit 84538d7627aa366ee72735e78fe44ddecd3895f6
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Feb 14 10:57:21 2019 +0100

    Ensure kuryr-controller recover from lb in ERROR status

    This patch ensures kuryr controller can recover from the situation
    when the created lb goes into ERROR status (instead of ACTIVE). Now,
    when the kuryr-controller finds the created lb, it checks its
    provisioning_status and if in ERROR status it will delete it and
    ensure a ResourceNotReady exception is triggered so that a new
    creation action is triggered after the deletion of the lb in ERROR
    status.

    Closes-Bug: 1815880
    Change-Id: I3f5de710a5ff37dee05f5f8826cb37c343141a08
    (cherry picked from commit 33594b870297aa88f15d73c221b6aa04709afe6d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 1.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.4.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.5.4 release.