Controller doesn't delete LB if wrong floating subnet was set in a Service

[livelace]

Openstack version: Queens, LBaaS v2 (legacy)
Kuryr version: Docker latest
Openshift/Kubernetes: 3.11

Description:

If a Service has externalIP value which _doesn't belong_ to Openstack floating subnets:

1. Service is created: Load Balancer is created and works, pass traffic to Pod as expected.
2. Service is deleted: Load Balancer still persist, not expected.

This problem was appeared during a deployment of Jenkins Helm chart(https://github.com/helm/charts/tree/master/stable/jenkins), that generate random extenalIP if Master.LoadBalancerIP is not set (I guess).

[Yossi Boaron (yossi-boaron-1234)]

Hi Livelace,

Could you please attach the relevant k8s service manifest (jenkins-79bd456cb4-89kcz)?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/632772

[livelace (k-a2min-2)]

It seems that Service has LoadBalancer type and it's a cause of the problem (not externalIP itself, sorry).
Service configuration in service.tar.gz

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/632772
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=0f9f5bc594b3824142b3ed6c0b6448ef3b2f8e79
Submitter: Zuul
Branch: master

commit 0f9f5bc594b3824142b3ed6c0b6448ef3b2f8e79
Author: Yossi Boaron <email address hidden>
Date: Wed Jan 23 18:01:06 2019 +0200

    Handle exception raised in FIP allocation

    In case an exception is raised in FIP allocation
    (due to wrong configuration), Kuryr will not annotate LB components
    and a result of that we'll end up with orphan LB after service deletion.
    With this patch, Kuryr will log the exception and
    annotate LB components.

    Change-Id: Iada0891786883d2348fca52a621bb196a3438df7
    Closes-Bug:#1813015

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 1.0.0 release.