Cannot disable octavia in devstack plugin

[Michal Rostecki]

Kuryr-kubernetes allows to disable octavia, but disabling octavia results in the following error:

+++ functions-common:oscwrap:2298 : command openstack loadbalancer create --name default/kubernetes --vip-address 10.0.0.129 --project 5d9ba986e5d440f1924215b804194e3e --vip-subnet-id k8s-service-subnet
+++ functions-common:oscwrap:2298 : openstack loadbalancer create --name default/kubernetes --vip-address 10.0.0.129 --project 5d9ba986e5d440f1924215b804194e3e --vip-subnet-id k8s-service-subnet
++ functions-common:oscwrap:2298 : out='openstack: '\''loadbalancer create --name default/kubernetes --vip-address 10.0.0.129 --project 5d9ba986e5d440f1924215b804194e3e --vip-subnet-id k8s-service-subnet'\'' is not an openstack command. See '\''openstack --help'\''.
Did you mean one of these?
  container create
  container delete
  container list
  container save
  container set
  container show
  container unset'
+ functions-common:oscwrap:1 : exit_trap
+ ./stack.sh:exit_trap:522 : local r=2
++ ./stack.sh:exit_trap:523 : jobs -p
+ ./stack.sh:exit_trap:523 : jobs=
+ ./stack.sh:exit_trap:526 : [[ -n '' ]]
+ ./stack.sh:exit_trap:532 : '[' -f /tmp/tmp.vjCwFOaDVO ']'
+ ./stack.sh:exit_trap:533 : rm /tmp/tmp.vjCwFOaDVO
+ ./stack.sh:exit_trap:537 : kill_spinner
+ ./stack.sh:kill_spinner:432 : '[' '!' -z '' ']'
+ ./stack.sh:exit_trap:539 : [[ 2 -ne 0 ]]
+ ./stack.sh:exit_trap:540 : echo 'Error on exit'
Error on exit
+ ./stack.sh:exit_trap:542 : type -p generate-subunit
+ ./stack.sh:exit_trap:543 : generate-subunit 1548238892 1101 fail
+ ./stack.sh:exit_trap:545 : [[ -z /opt/stack/logs ]]
+ ./stack.sh:exit_trap:548 : /opt/stack/devstack/tools/worlddump.py -d /opt/stack/logs
+ ./stack.sh:exit_trap:557 : exit 2
stack@k8s1:~/devstack$

Also, a lot of operations and values inside the plugin depend on information from load balancer. The proper fix should wrap all operation which require LB in `if is_service_enabled octavia` statements and ensure that devstack is able to deploy openstack without octavia.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/632999

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/632999
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=3441a700b1e8a51c71e885b857df0a0c86972cad
Submitter: Zuul
Branch: master

commit 3441a700b1e8a51c71e885b857df0a0c86972cad
Author: Michal Rostecki <email address hidden>
Date: Wed Jan 23 17:03:27 2019 +0100

    devstack: Create LB objects only if Octavia is enabled

    kuryr-kubernetes used to allow to disable Octavia, but then lbaasv2 was
    used instead for creating all LB related objects. Since lbaasv2 support
    is dropped, devstack plugin tries to create LB prjects even when Octavia
    is disabled.

    After this change, devstack plugin does not create any LB objects if
    Octavia is disabled.

    Change-Id: I0749b0d0388dcbca558434a5abc2a97bc0dcbe35
    Closes-Bug: #1812997

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 1.0.0 release.