Tests in test_public_ip.py not running the methods they're testing
Bug #1798782 reported by
Michal Dulko
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| kuryr-kubernetes |
Fix Released
|
Undecided
|
Michal Dulko | ||
Bug Description
Looks like all the tests in test_public_ip.py are fundametaly broken
because of mocking *all* the methods of FipPubIpDriver causing the
tested method to not be exectued. This commit fixes that.
| Changed in kuryr-kubernetes: | |
| assignee: | nobody → Michal Dulko (michal-dulko-f) |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to kuryr-kubernetes (master) | #1 |
| Changed in kuryr-kubernetes: | |
| status: | In Progress → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/kuryr-kubernetes 0.6.0 | #2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit e176dd35cfcceed
Author: Michał Dulko <email address hidden>
Date: Thu Oct 18 13:56:55 2018 +0200
Fix tests in test_public_ip.py
Looks like all the tests in test_public_ip.py were fundametaly broken
because of mocking *all* the methods of FipPubIpDriver causing the
tested method to not be exectued. This commit fixes that.
Closes-Bug: 1798782
Change-Id: I6286db8d70a111