kuryr-controller unable to recover from failure after FIP association

[Michal Dulko]

If kuryr-controller was restarted after it associated FIP to the LB for a Service but before it was saved into the LBaaSState annotation, it fails next tries to associate that FIP. On Conflict error from Neutron we should check if the FIP is associated correctly and proceed if that's the case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/611542

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/611542
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=a5ee0fdb061ac5546e90c3f922bfc2c266378b93
Submitter: Zuul
Branch: master

commit a5ee0fdb061ac5546e90c3f922bfc2c266378b93
Author: Michał Dulko <email address hidden>
Date: Thu Oct 18 10:54:21 2018 +0200

    Ignore exc on FIP association if state is correct

    If we're getting Conflict exception on FIP association we should check
    if that FIP isn't already associated correctly and if that's the case
    ignore the exception. This commit implements that behavior.

    This solves the case when kuryr-controller is restarted after FIP
    association but before that fact is saved into LBaaSState annotation.

    Change-Id: I1126906516b787a5ce4dc5421f5323ad4f4b331c
    Closes-Bug: 1798549

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/623474

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/623474
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=3245f3e9e2535b8d1f76d1bb73105671c645f157
Submitter: Zuul
Branch: stable/rocky

commit 3245f3e9e2535b8d1f76d1bb73105671c645f157
Author: Michał Dulko <email address hidden>
Date: Thu Oct 18 10:54:21 2018 +0200

    Ignore exc on FIP association if state is correct

    If we're getting Conflict exception on FIP association we should check
    if that FIP isn't already associated correctly and if that's the case
    ignore the exception. This commit implements that behavior.

    This solves the case when kuryr-controller is restarted after FIP
    association but before that fact is saved into LBaaSState annotation.

    Change-Id: I1126906516b787a5ce4dc5421f5323ad4f4b331c
    Closes-Bug: 1798549
    (cherry picked from commit a5ee0fdb061ac5546e90c3f922bfc2c266378b93)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.5.3 release.