cni_ds_init should not be pid1 of cni daemon pod

Bug #1792539 reported by Antoni Segura Puimedon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kuryr-kubernetes
Fix Released
Undecided
Antoni Segura Puimedon

Bug Description

In containerized CNI, the executable that docker/crio runs is cni_ds_init. cni_ds_init is a shell script that sets up the environment and finally either runs the daemon executable or sleeps, depending of whether the deployment calls for a CNI daemon or just an executable.

The problem with doing that is that the PID 1 will be the shell script that is not doing anything once it reaches the cni daemon executable or sleep. This means the reported main process for the container/pod will not be
the one doing the job.

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-kubernetes (master)

Fix proposed to branch: master
Review: https://review.openstack.org/602573

Changed in kuryr-kubernetes:
assignee: nobody → Antoni Segura Puimedon (celebdor)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-kubernetes (master)

Reviewed: https://review.openstack.org/602573
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=fa927d4890c44d680b520d8d54fd5485cdff6fb6
Submitter: Zuul
Branch: master

commit fa927d4890c44d680b520d8d54fd5485cdff6fb6
Author: Antoni Segura Puimedon <email address hidden>
Date: Fri Sep 14 10:44:39 2018 +0200

    cni_ds_init: exec into the main process

    This will make the right main process for the cni daemon
    container to be reported.

    Closes-Bug: 1792539

    Change-Id: Ic57fbe20b7bf396ea92e0c2cbcca42814ae2a119
    Signed-off-by: Antoni Segura Puimedon <email address hidden>

Changed in kuryr-kubernetes:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-kubernetes (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/603034

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-kubernetes (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/603035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-kubernetes (stable/queens)

Reviewed: https://review.openstack.org/603035
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=700606c25b77bf03fd3d1b5f443272b66774bf24
Submitter: Zuul
Branch: stable/queens

commit 700606c25b77bf03fd3d1b5f443272b66774bf24
Author: Antoni Segura Puimedon <email address hidden>
Date: Fri Sep 14 10:44:39 2018 +0200

    cni_ds_init: exec into the main process

    This will make the right main process for the cni daemon
    container to be reported.

    Closes-Bug: 1792539

    Change-Id: Ic57fbe20b7bf396ea92e0c2cbcca42814ae2a119
    Signed-off-by: Antoni Segura Puimedon <email address hidden>
    (cherry picked from commit fa927d4890c44d680b520d8d54fd5485cdff6fb6)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-kubernetes (stable/rocky)

Reviewed: https://review.openstack.org/603034
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=1a55b6c07a09515add37f2fb20caf545479aa2c6
Submitter: Zuul
Branch: stable/rocky

commit 1a55b6c07a09515add37f2fb20caf545479aa2c6
Author: Antoni Segura Puimedon <email address hidden>
Date: Fri Sep 14 10:44:39 2018 +0200

    cni_ds_init: exec into the main process

    This will make the right main process for the cni daemon
    container to be reported.

    Closes-Bug: 1792539

    Change-Id: Ic57fbe20b7bf396ea92e0c2cbcca42814ae2a119
    Signed-off-by: Antoni Segura Puimedon <email address hidden>
    (cherry picked from commit fa927d4890c44d680b520d8d54fd5485cdff6fb6)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kuryr-kubernetes 0.5.1

This issue was fixed in the openstack/kuryr-kubernetes 0.5.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kuryr-kubernetes 0.6.0

This issue was fixed in the openstack/kuryr-kubernetes 0.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kuryr-kubernetes 0.4.6

This issue was fixed in the openstack/kuryr-kubernetes 0.4.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.