kuryr-daemon broken with Flask update

[Michal Dulko]

Due to recent bump in global-requirements.txt, kuryr-daemon is broken. This is because it's now required to explicitly set threaded=False when starting the multi-threaded Flask app. Otherwise we get the traceback below:

Jun 25 05:54:08.199115 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.198 6048 INFO werkzeug [-] * Running on http://127.0.0.1:8090/ (Press CTRL+C to quit)
Jun 25 05:54:08.219048 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service [-] Failed to start kuryr-daemon.: ValueError: cannot have a multithreaded and multi process server.
Jun 25 05:54:08.219220 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service Traceback (most recent call last):
Jun 25 05:54:08.219335 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service File "/opt/stack/kuryr-kubernetes/kuryr_kubernetes/cni/daemon/service.py", line 132, in run
Jun 25 05:54:08.219455 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service processes=CONF.cni_daemon.worker_num)
Jun 25 05:54:08.219563 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 943, in run
Jun 25 05:54:08.219671 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service run_simple(host, port, self, **options)
Jun 25 05:54:08.219776 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service File "/usr/local/lib/python2.7/dist-packages/werkzeug/serving.py", line 814, in run_simple
Jun 25 05:54:08.219893 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service inner()
Jun 25 05:54:08.219999 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service File "/usr/local/lib/python2.7/dist-packages/werkzeug/serving.py", line 774, in inner
Jun 25 05:54:08.220117 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service fd=fd)
Jun 25 05:54:08.220233 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service File "/usr/local/lib/python2.7/dist-packages/werkzeug/serving.py", line 656, in make_server
Jun 25 05:54:08.220341 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service raise ValueError("cannot have a multithreaded and "
Jun 25 05:54:08.220440 ubuntu-xenial-ovh-bhs1-0000317834 kuryr-daemon[5854]: 2018-06-25 05:54:08.204 6044 ERROR kuryr_kubernetes.cni.daemon.service ValueError: cannot have a multithreaded and multi process server.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/577760

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/577760
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=7a4da57c272d42514e9d2e6447fafe7e0f7e9784
Submitter: Zuul
Branch: master

commit 7a4da57c272d42514e9d2e6447fafe7e0f7e9784
Author: Michał Dulko <email address hidden>
Date: Mon Jun 25 11:26:34 2018 +0200

    Explicitly set threaded=False when starting Flask

    Due to global-requirements update kuryr-daemon got broken as it's now
    required to explicitly set threaded=False when starting multi-process
    Flask app. This commit fixes that. Please note that this change should
    not break older versions of Flask.

    Depends-On: https://review.openstack.org/#/c/578195
    Change-Id: I11e0b8b6e66ede00f08e182e4e3f4829c2936e1f
    Closes-Bug: 1778483

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.5.0 release.