kuryr-kubernetes

The watcher retry mechanism fails to stop watching resources

Bug #1777632 reported by Antoni Segura Puimedon on 2018-06-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	kuryr-kubernetes	Fix Released	Critical	Antoni Segura Puimedon

Bug Description

Since the watched path is not removed in the event of a graceful exit, the watch loop will try to watch again, breaking the graceful exit contract.

Tags:

Antoni Segura Puimedon (celebdor) on 2018-06-19

Changed in kuryr-kubernetes:
status:	New → Triaged
importance:	Undecided → Critical

OpenStack Infra (hudson-openstack) on 2018-06-19

Changed in kuryr-kubernetes:
assignee:	nobody → Antoni Segura Puimedon (celebdor)
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-22: Fix merged to kuryr-kubernetes (master)

Reviewed: https://review.openstack.org/575771
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=9a8716087dcccc8afa53e9d1c760a2f3033596a8
Submitter: Zuul
Branch: master

commit 9a8716087dcccc8afa53e9d1c760a2f3033596a8
Author: Antoni Segura Puimedon <email address hidden>
Date: Fri Jun 15 17:22:17 2018 +0200

Really use the test handler

    We had a false positive here and it was raising and swallowing some
    exceptions. Fixing it exposed the fact that we were not really removing
    the resource from the watch so it would loop forever trying to find more
    events instead of finishing.

    Change-Id: I96bc2d6ac7951c1cbc78c74e810577fc35587d39
    Closes-Bug: #1777155
    Closes-Bug: #1777632
    Signed-off-by: Antoni Segura Puimedon <email address hidden>

Changed in kuryr-kubernetes:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-25: Fix proposed to kuryr-kubernetes (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/577728

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-26: Fix merged to kuryr-kubernetes (stable/queens)

Reviewed: https://review.openstack.org/577728
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=7aaef634d62a43936a229381c88aebb04bb0254b
Submitter: Zuul
Branch: stable/queens

commit 7aaef634d62a43936a229381c88aebb04bb0254b
Author: Antoni Segura Puimedon <email address hidden>
Date: Fri Jun 15 17:22:17 2018 +0200

Really use the test handler

    Change-Id: I96bc2d6ac7951c1cbc78c74e810577fc35587d39
    Closes-Bug: #1777155
    Closes-Bug: #1777632
    Signed-off-by: Antoni Segura Puimedon <email address hidden>
    (cherry picked from commit 9a8716087dcccc8afa53e9d1c760a2f3033596a8)